[SYCL][Reduction] Fix issue with multiple buffer reductions #6680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduAuxCGFunc has different output target between the case when number of work groups is one or more, while the kernel executed is the same. As such we were re-using the same kernel code trying to adjust its name so that a single one isn't used two times (#WGs check is a run-time one). We used accessors' types for that but that approach only worked for USM case (ptr vs buffer accessor for the output type depending on #WGs). In case when the original reduction variable used a buffer, both type were the same resulting in a "definition with same mangled name" error. Use something that has distinct types to name the kernel.
aelovikov-intel
added a commit
to aelovikov-intel/llvm-test-suite
that referenced
this pull request
Aug 31, 2022
v-klochkov
approved these changes
Aug 31, 2022
steffenlarsen
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Sep 2, 2022
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduAuxCGFunc has different output target between the case when number
of work groups is one or more, while the kernel executed is the same. As
such we were re-using the same kernel code trying to adjust its name so
that a single one isn't used two times (#WGs check is a run-time one).
We used accessors' types for that but that approach only worked for USM
case (ptr vs buffer accessor for the output type depending on #WGs). In
case when the original reduction variable used a buffer, both type were
the same resulting in a "definition with same mangled name" error. Use
something that has distinct types to name the kernel.