Skip to content

[SYCL][DOC] Add noexcept specifier for has_property() #6632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steffenlarsen merged 1 commit into from
Aug 23, 2022
Merged

[SYCL][DOC] Add noexcept specifier for has_property() #6632

steffenlarsen merged 1 commit into from
Aug 23, 2022

Conversation

@KornevNikita
Copy link
Contributor

@KornevNikita KornevNikita commented Aug 23, 2022

As discussed here #6614 has_property() version for non compile-time-properties should be marked as noexcept.

@KornevNikita KornevNikita requested a review from a team as a code owner August 23, 2022 15:14
@KornevNikita KornevNikita mentioned this pull request Aug 23, 2022
Merged
steffenlarsen
steffenlarsen approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@steffenlarsen steffenlarsen merged commit 7805aa3 into intel:sycl Aug 23, 2022
@KornevNikita KornevNikita deleted the update-accessor-property-spec branch September 2, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KornevNikita @steffenlarsen