Skip to content

[SYCL] Finally fix iostream_proxy.hpp #6517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2022
Merged

[SYCL] Finally fix iostream_proxy.hpp #6517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sycl/include/sycl/detail/iostream_proxy.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@
#include <ostream>

namespace std {
#ifdef _WIN32
#if defined(_MT) && defined(_DLL)
#define __SYCL_EXTERN_STREAM_ATTRS __declspec(dllimport)
#else
#define __SYCL_EXTERN_STREAM_ATTRS
#endif // _WIN32
#endif // defined(_MT) && defined(_DLL)

/// Linked to standard input
extern __SYCL_EXTERN_STREAM_ATTRS istream cin;
/// Linked to standard output
Expand Down
4 changes: 0 additions & 4 deletions sycl/test/regression/fsycl-host-compiler-win.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@

#include <sycl/sycl.hpp>

// FIXME: Modify <sycl/details/iostream_proxy.hpp> so that it would require
// proper libs via "#pragma comment(lib, ...)".
#include <iostream>

#ifndef DEFINE_CHECK
#error predefined macro not set
#endif // DEFINE_CHECK
Expand Down