[SYCL][ABI-break] Remove redundant methods under sycl::handler #6461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[SYCL][ABI-break] Remove kernel::get_work_group_info (intel#6414)
Signed-off-by: Rauf, Rana <[email protected]>
Signed-off-by: Rauf, Rana <[email protected]>
aelovikov-intel
previously approved these changes
Jul 21, 2022
Signed-off-by: Rauf, Rana <[email protected]> Format Signed-off-by: Rauf, Rana <[email protected]>
bader
changed the title
|
Minor style wording: "methods" are named "member functions" in C++. |
|
Ohh, yeah, sorry. Still stuck in Java terms |
|
@intel/llvm-gatekeepers slight ping to merge commit. Thanks |
1 similar comment
|
@intel/llvm-gatekeepers slight ping to merge commit. Thanks |
|
@raaiq1, can you resolve a conflict please? |
raaiq1
dismissed stale reviews from cperkinsintel and aelovikov-intel
via
f78c01d
[SYCL][ABI-Break] Remove obsolete methods from memory_manager (intel#6522)
Signed-off-by: Rauf, Rana <[email protected]>
aelovikov-intel
previously approved these changes
Aug 4, 2022
Signed-off-by: Rauf, Rana <[email protected]>
Previous patch was implemented by splitting off piece of a bigger patch by completely eliminating "cl" namespace and then addressing the local failures. Local testing didn't cover all possible platforms so these occurrences were left untouched. This is a wider application of grep/sed, but it's still not complete as some instances of "cl" namespace references cannot be eliminated in an NFC change (e.g. everything affecting/affected by mangling as in clang or some tools). The reason I'm committing these changes separately is to ease the review of the actual non-NFC PR later.
When _MT and _DLL are both defined, the user has passed /MD or /MDd and is dynamically linking in the runtimes. Because std::cout etc are data, they need to be marked dllimport in that case or else the linker cannot find them.
Uplift GPU RT version for Linux to 22.29.23750 Co-authored-by: GitHub Actions <[email protected]>
Uplift GPU RT version for Linux to 22.30.23789 Co-authored-by: GitHub Actions <[email protected]>
Signed-off-by: Rauf, Rana <[email protected]>
…#6519) Support for new FPGA attribute called [[intel::fpga_pipeline(N)]] on intel#6254 is no longer needed. This patch removes the support from frontend. Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Rauf, Rana <[email protected]>
|
Alternate PR at: #6529 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the following redundant methods:
void extractArgsAndReqsFromLambda(char *LambdaPtr, size_t KernelArgsNum,
const detail::kernel_param_desc_t *KernelArgs);
void processArg(void *Ptr, const detail::kernel_param_kind_t &Kind,
const int Size, const size_t Index, size_t &IndexShift,
bool IsKernelCreatedFromSource);
static id<I> getDelinearizedIndex(const range<I> Range, const size_t Index);
where I is could be {1,2,3};