Skip to content

[NFCI][SYCL] Refactor reduction implementation #6445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jul 27, 2022
Merged

[NFCI][SYCL] Refactor reduction implementation #6445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
8c68366
[NFC][SYCL] Remove Algorithm from reducer's template params
aelovikov-intel Jul 13, 2022
417df41
[WIP] SFINAE-out reduction_impl ctors
aelovikov-intel Jul 14, 2022
a2718ef
Move my_is_* into base class
aelovikov-intel Jul 14, 2022
7c686fc
SFINAE-out base class ctors as well
aelovikov-intel Jul 14, 2022
3b1fd02
Init single reference to user reduction var
aelovikov-intel Jul 14, 2022
edc843a
Switch uses to generic/template MRedOut
aelovikov-intel Jul 14, 2022
445e871
Make MRedOut the *only* version of the user's reduction var
aelovikov-intel Jul 14, 2022
3a4d91d
Simplification of overloads with/without known identity
aelovikov-intel Jul 14, 2022
862a424
Move RedOutVar to the end of the template params list
aelovikov-intel Jul 14, 2022
96502df
Remove IsUSM from default_reduction_algorithm
aelovikov-intel Jul 14, 2022
252a71c
Remove IsPlaceholder from default_reduction_algorithm
aelovikov-intel Jul 15, 2022
c15825b
Remove default_reduction_algorithm
aelovikov-intel Jul 15, 2022
add7ff2
make_reduction for partial types deduction + process buffer/span on t…
aelovikov-intel Jul 15, 2022
4eff2bb
Sort ctors, minor change
aelovikov-intel Jul 15, 2022
630b58c
Minor improvements
aelovikov-intel Jul 15, 2022
5c20d60
clang-format
aelovikov-intel Jul 15, 2022
4aa7439
Fix a typo in a comment
aelovikov-intel Jul 15, 2022
5e305dc
Benefit from accessor's CTAD
aelovikov-intel Jul 15, 2022
cf039fe
WIP Simplify getWriteMemForPartialReds
aelovikov-intel Jul 15, 2022
8967bf3
Update associateWithHandler uses
aelovikov-intel Jul 16, 2022
156f9ee
Remove useless single-callsite wrapper
aelovikov-intel Jul 18, 2022
b6127e3
Fix bug
aelovikov-intel Jul 22, 2022
914fcfa
Rename the trait
aelovikov-intel Jul 27, 2022
a96dfac
Add a comment
aelovikov-intel Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading