Skip to content

[SYCL][HIP] Implement PI_DEVICE_INFO_ATOMIC_64 for HIP #6429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2022
Merged

[SYCL][HIP] Implement PI_DEVICE_INFO_ATOMIC_64 for HIP #6429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion sycl/plugins/hip/pi_hip.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1767,8 +1767,17 @@ pi_result hip_piDeviceGetInfo(pi_device device, pi_device_info param_name,
return getInfo(param_value_size, param_value, param_value_size_ret, value);
}

case PI_DEVICE_INFO_ATOMIC_64: {
// TODO: Reconsider it when AMD supports SYCL_USE_NATIVE_FP_ATOMICS.
hipDeviceProp_t props;
cl::sycl::detail::pi::assertion(
hipGetDeviceProperties(&props, device->get()) == hipSuccess);
return getInfo(param_value_size, param_value, param_value_size_ret,
props.arch.hasGlobalInt64Atomics &&
props.arch.hasSharedInt64Atomics);
}

// TODO: Implement.
case PI_DEVICE_INFO_ATOMIC_64:
case PI_DEVICE_INFO_ATOMIC_MEMORY_ORDER_CAPABILITIES:
// TODO: Investigate if this information is available on HIP.
case PI_DEVICE_INFO_ATOMIC_MEMORY_SCOPE_CAPABILITIES:
Expand Down