[SYCL] Introduce SYCL_PI_SUPPRESS_ERROR_MESSAGE #6428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/verify with: intel/llvm-test-suite#1089 |
sycl/doc/EnvironmentVariables.md
Outdated
| @@ -169,6 +169,7 @@ variables in production code.</span> | |||
| | Environment variable | Values | Description | | |||
| | -------------------- | ------ | ----------- | | |||
| | `SYCL_PI_CUDA_ENABLE_IMAGE_SUPPORT` (experimental) | Any(\*) | Enable support of images. This option is experimental since the image support is not fully implemented. | | |||
| | `SYCL_PI_SUPPRESS_ERROR_MESSAGE` (experimental) | Any(\*) | Suppress printing of error message, only used for CI in order not to interrupt errors generated by underlying toolchains. | | |||
There was a problem hiding this comment.
Should this be moved to the greater SYCL RT env var section since this is not CUDA specific?
It'd be good to clarify in the descriptions what are the errors being suppressed and how execution proceeds with the errors being silent.
There was a problem hiding this comment.
Yeap, I think you are right, I'll move it to Debugging variables for DPC++ Runtime and add clarifications.
smaslov-intel
approved these changes
Jul 12, 2022
Yeap, it's been done here: https://github.com/intel/llvm-test-suite/pull/1089/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent
check_errorfrom printing error message. This is handy in CI where we would like to match on messages generated by the underlying driver, over which we have no control, andcheck_errorcould garble that output.Fixes: #6416