[Matrix][SYCL] Add explicit conversion in wi_element when it is necessary #5279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sary Previously, there was a potential issue of deduced conflicting types because we didn't take integral promotion into consideration Now, we add explicit conversion where integral promotion might happen to avoid such issues to appear.
yubingex007-a11y
changed the title
|
Hi, @dkhaldi this is for the second bug which you mentioned, https://godbolt.org/z/f143vE58x is a reproduce for slice’s bug, and it is an issue of template deduction and integral promotion. It can be fixed by https://godbolt.org/z/M3j3KcEhh. |
|
@bader is the checkin's fail a known issue? |
|
@yubingex007-a11y, no. |
|
I've opened intel/llvm-test-suite#720 to fix these tests. |
Awesome thanks for your quick response. |
vladimirlaz
approved these changes
Jan 11, 2022
|
@bader could you help us merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was a potential issue of deduced conflicting types because we didn't take integral promotion into consideration
Now, we add explicit conversion where integral promotion might happen to avoid such issues to appear.