[SYCL] Fix backwards compatibility for libraries in archive format #4685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `-sycldevice` triple environment removal (as performed in intel#3929), backwards compatibility has been enforced for SYCL objects/object-format libraries only. To ensure that `.a` libraries (archives) built by older compiler versions are usable with newer compiler version, adjust `clang-offload-deps` to consider `-sycldevice`-marked symbols when encountering a SYCL target. Signed-off-by: Artem Gindinson <[email protected]>
AGindinson
requested review from
hchilama,
mdtoguchi and
mlychkov
as code owners
hchilama
approved these changes
Oct 1, 2021
mlychkov
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
-sycldevicetriple environment removal (as performed in#3929), backwards compatibility has been enforced for SYCL
objects/object-format libraries only. To ensure that
.alibraries(archives) built by older compiler versions are usable with newer
compiler version, adjust
clang-offload-depsto consider-sycldevice-marked symbols when encountering a SYCL target.Signed-off-by: Artem Gindinson [email protected]