Skip to content

[SYCL] Fix true missing on Windows #4211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2021
Merged

[SYCL] Fix true missing on Windows #4211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions sycl/test/on-device/lit.cfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,8 @@ def getDeviceCount(device_type):

found_at_least_one_device = False

cpu_run_substitute = "true"
cpu_run_on_linux_substitute = "true "
cpu_run_substitute = "echo "
cpu_run_on_linux_substitute = "echo "
Comment on lines +194 to +195
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are arguments optional for echo on both windows and linux?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're not, but a) I didn't find the case when we have no args b) both can accept more than 1 argument

cpu_check_substitute = ""
cpu_check_on_linux_substitute = ""

Expand All @@ -213,8 +213,8 @@ def getDeviceCount(device_type):
config.substitutions.append( ('%CPU_CHECK_PLACEHOLDER', cpu_check_substitute) )
config.substitutions.append( ('%CPU_CHECK_ON_LINUX_PLACEHOLDER', cpu_check_on_linux_substitute) )

gpu_run_substitute = "true"
gpu_run_on_linux_substitute = "true "
gpu_run_substitute = "echo "
gpu_run_on_linux_substitute = "echo "
gpu_check_substitute = ""
gpu_check_on_linux_substitute = ""

Expand Down Expand Up @@ -244,7 +244,7 @@ def getDeviceCount(device_type):
config.substitutions.append( ('%GPU_CHECK_PLACEHOLDER', gpu_check_substitute) )
config.substitutions.append( ('%GPU_CHECK_ON_LINUX_PLACEHOLDER', gpu_check_on_linux_substitute) )

acc_run_substitute = "true"
acc_run_substitute = "echo "
acc_check_substitute = ""
if getDeviceCount("accelerator")[0]:
found_at_least_one_device = True
Expand Down