[SYCL] Fix true missing on Windows #4211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to `echo` instead of Unix-specific `true`
|
Will something similar be feasible for the test suite? |
Working on that, however there's a bit more than just |
|
@steffenlarsen would you please try intel/llvm-test-suite#383? Should fix your issue. |
s-kanaev
reviewed
Jul 30, 2021
Comment on lines
+194
to
+195
| cpu_run_substitute = "echo " | ||
| cpu_run_on_linux_substitute = "echo " |
There was a problem hiding this comment.
Are arguments optional for echo on both windows and linux?
There was a problem hiding this comment.
They're not, but a) I didn't find the case when we have no args b) both can accept more than 1 argument
smaslov-intel
approved these changes
Jul 30, 2021
zahiraam
pushed a commit
to zahiraam/llvm-1
that referenced
this pull request
Aug 2, 2021
Switch to `echo` instead of Unix-specific `true`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to
echoinstead of Unix-specifictrue