Skip to content

[SYCL] Make spelling of Debug value for CMAKE_BUILD_TYPE variable case insensitive #4069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2021
Merged

[SYCL] Make spelling of Debug value for CMAKE_BUILD_TYPE variable case insensitive #4069

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
220b40b
[SYCL] Make cmake file for unit-tests more robust
Jul 7, 2021
d891bc0
Merge remote-tracking branch 'public/sycl' into fix-cmake-unit-test-win
Jul 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sycl/cmake/modules/AddSYCLUnitTest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ macro(add_sycl_unittest test_dirname link_variant)
# Enable exception handling for these unit tests
set(LLVM_REQUIRES_EH 1)

if (MSVC AND CMAKE_BUILD_TYPE MATCHES "Debug")
string(TOLOWER "${CMAKE_BUILD_TYPE}" build_type_lower)
if (MSVC AND build_type_lower MATCHES "debug")
set(sycl_obj_target "sycld_object")
set(sycl_so_target "sycld")
else()
Expand Down