Skip to content

[docs] Update ESIMD docs: SYCL-ESIMD co-existence #3477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2021
Merged

[docs] Update ESIMD docs: SYCL-ESIMD co-existence #3477

merged 3 commits into from
Apr 8, 2021

Conversation

DenisBakhvalov
Copy link
Contributor

This patch updates ESIMD documentation after implementation
of SYCL-ESIMD co-existence feature was completed.

@DenisBakhvalov
[docs] Update ESIMD docs: SYCL-ESIMD co-existence
df42a3a 
This patch updates ESIMD documentation after implementation
of SYCL-ESIMD co-existence feature was completed.
@DenisBakhvalov DenisBakhvalov requested a review from kbobrovs as a code owner April 2, 2021 16:57
@DenisBakhvalov DenisBakhvalov mentioned this pull request Apr 2, 2021
Merged
@DenisBakhvalov
Copy link
Contributor Author

@kbobrovs , please review.

@DenisBakhvalov
Copy link
Contributor Author

@kbobrovs , please review.

@kbobrovs, ping

kbobrovs
kbobrovs reviewed Apr 6, 2021
View reviewed changes
sycl/doc/extensions/ExplicitSIMD/README.md Outdated
- Usual and ESIMD DPC++ kernels can not co-exist in the same application in most
cases
- Interoperability between regular SYCL and ESIMD kernels is not supported.
I.e., it's not possible to call ESIMD code from SYCL and vise-versa.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can in fact call SYCL functions with bodies from ESIMD, so please rephrase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrased.

@DenisBakhvalov DenisBakhvalov requested a review from kbobrovs April 7, 2021 17:56
kbobrovs
kbobrovs reviewed Apr 7, 2021
View reviewed changes
Copy link
Contributor

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the phrase at the bottom as well:
"Interoperability between regular SYCL and ESIMD kernels is not yet supported. I.e., it's not possible to invoke an ESIMD kernel from SYCL kernel and vice-versa"

@DenisBakhvalov
Copy link
Contributor Author

Please update the phrase at the bottom as well:
"Interoperability between regular SYCL and ESIMD kernels is not yet supported. I.e., it's not possible to invoke an ESIMD kernel from SYCL kernel and vice-versa"

Thanks, done.

@DenisBakhvalov DenisBakhvalov requested a review from kbobrovs April 7, 2021 20:10
@kbobrovs kbobrovs merged commit dbfaa7f into intel:sycl Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kbobrovs kbobrovs kbobrovs approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DenisBakhvalov @kbobrovs