Skip to content

[SYCL] Fix build log for L0 plugin #2479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 21, 2020
Merged

Conversation

gmlueck
Copy link
Contributor

@gmlueck gmlueck commented Sep 15, 2020

The build log was not preserved for failed compile and link
operations in the L0 plugin, and this prevented the build log
information from being included in the SYCL "compile_program_error"
exception. Fix this and add a test.

The build log was not preserved for failed compile and link
operations in the L0 plugin, and this prevented the build log
information from being included in the SYCL "compile_program_error"
exception.  Fix this and add a test.
@gmlueck gmlueck requested review from smaslov-intel and a team as code owners September 15, 2020 19:45
@gmlueck
Copy link
Contributor Author

gmlueck commented Sep 15, 2020

The three failures in pre-commit testing are all due to the same test failure: "Driver/sycl-intelfpga-static-lib.cpp". It appears that this failure is unrelated to my PR, and was introduced in #2400. See https://github.com/intel/llvm/actions/runs/255280893

@romanovvlad
Copy link
Contributor

romanovvlad commented Sep 18, 2020

@gmlueck Could you please merge your branch with sycl one to make pre-commit passing.
@smaslov-intel Could you please review the patch?

@romanovvlad romanovvlad merged commit 638b71b into intel:sycl Sep 21, 2020
@gmlueck gmlueck deleted the gmlueck/fix-log branch September 21, 2020 11:46
jsji pushed a commit that referenced this pull request Apr 4, 2024
* Run validation where it was intended
* Do the expected source language check

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@5242c3888ec01b7
kbenzie added a commit to kbenzie/intel-llvm that referenced this pull request Feb 17, 2025
…eTests

Parameterize CTS tests across all available adapters and devices.
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
Parameterize CTS tests across all available adapters and devices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants