Skip to content

[SYCL] Eliminated events dependency on queue. #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

KarachunIvan
Copy link
Contributor

@KarachunIvan KarachunIvan commented Aug 27, 2020

This patch removes events dependency on queue according to
suggestions from #1226.

Signed-off-by: Ivan Karachun [email protected]

@KarachunIvan KarachunIvan requested a review from a team as a code owner August 27, 2020 11:40
@KarachunIvan KarachunIvan marked this pull request as draft August 27, 2020 13:00
@alexbatashev
Copy link
Contributor

Would be great to see some motivation in PR description.

This patch removes events dependency on queue according to
suggestions from intel#1226.

Signed-off-by: Ivan Karachun <[email protected]>
@KarachunIvan KarachunIvan force-pushed the report_async_exceptions_via_context branch from 1fa2ade to b83b7d3 Compare September 4, 2020 14:35
@KarachunIvan KarachunIvan marked this pull request as ready for review September 4, 2020 14:36
@KarachunIvan
Copy link
Contributor Author

Would be great to see some motivation in PR description.

Done

Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit 31843cc into intel:sycl Sep 4, 2020
jsji pushed a commit that referenced this pull request Feb 29, 2024
undefinedFor SPIR-V 1.4 and earlier, the Id operand of OpGroupNonUniformBroadcast must come from a constant instruction.

Ensure that any emitted SPIR-V module using a non-constant Id operand declares SPIR-V version 1.5. Bail out if the maximum SPIR-V version was restricted to < 1.5, to avoid producing invalid SPIR-V.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@64fe75e388dc3b7
jsji pushed a commit that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants