[SYCL] Remove unnecessary fallback-cassert file for CUDA/AMD assert #20967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jinge90 <[email protected]>
jinge90
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: jinge90 <[email protected]>
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: jinge90 <[email protected]>
jinge90
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: jinge90 <[email protected]>
jinge90
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: jinge90 <[email protected]>
jinge90
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: jinge90 <[email protected]>
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jinge90
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
jinge90
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: jinge90 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have removed fallback device library jit-link path, so there is no need to have separate libsycl-fallback-* library files. The only exception is imf libraries for SPIRV targets.
This PR is a series of patches to clean up all unnecessary libsycl-fallback-* library files exposing _devicelib* APIs, we clean up libsycl-fallback-cassert for CUDA/AMD target.
For Intel Target, the __devicelib_assert_fail is provided by IGC or OpenCL CPU runtime and for AMD/CUDA target, underlying runtime provides similar function '__assertfail'.