Skip to content

[SYCL] Correction to recognition of constant-size array. #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 15, 2020
Merged

[SYCL] Correction to recognition of constant-size array. #2082

merged 12 commits into from
Jul 15, 2020

Conversation

rdeodhar
Copy link
Contributor

@rdeodhar rdeodhar commented Jul 9, 2020

Signed-off-by: rdeodhar [email protected]

@premanandrao
Copy link
Contributor

Looks good to me. @erichkeane ?

erichkeane
erichkeane reviewed Jul 9, 2020
View reviewed changes
erichkeane
erichkeane previously approved these changes Jul 9, 2020
View reviewed changes
Fznamznon
Fznamznon previously approved these changes Jul 10, 2020
View reviewed changes
@Fznamznon Fznamznon mentioned this pull request Jul 10, 2020
Closed
@rdeodhar rdeodhar dismissed stale reviews from Fznamznon, elizabethandrews, and erichkeane via 7c287a3 July 13, 2020 21:31
@bader bader requested a review from elizabethandrews July 14, 2020 15:39
elizabethandrews
elizabethandrews reviewed Jul 14, 2020
View reviewed changes
Copy link
Contributor

@elizabethandrews elizabethandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small issue with test. I think a CodeGen or runtime test is also useful to ensure it works correctly but I am ok with it as a separate PR since this fix has high priority.

@rdeodhar rdeodhar requested a review from a team as a code owner July 14, 2020 17:56
@rdeodhar rdeodhar requested a review from rbegam July 14, 2020 17:56
elizabethandrews
elizabethandrews previously approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@elizabethandrews elizabethandrews left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE changes LGTM. Thanks!

elizabethandrews
elizabethandrews requested changes Jul 15, 2020
View reviewed changes
@bader bader merged commit 9b9639a into intel:sycl Jul 15, 2020
@rdeodhar rdeodhar deleted the akp7 branch July 15, 2020 16:12
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
@RossBrunton
Merge pull request #2082 from RossBrunton/ross/multiadapt
165c448 
[CI] Add "loader" support to conformance testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanovvlad romanovvlad romanovvlad approved these changes

@elizabethandrews elizabethandrews elizabethandrews approved these changes

@Fznamznon Fznamznon Fznamznon left review comments

@premanandrao premanandrao Awaiting requested review from premanandrao

@rbegam rbegam Awaiting requested review from rbegam

+1 more reviewer

@erichkeane erichkeane erichkeane left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rdeodhar @premanandrao @erichkeane @Fznamznon @romanovvlad @elizabethandrews @bader