Skip to content

Conversation

@PatKamin
Copy link
Contributor

@PatKamin PatKamin commented Nov 4, 2025

There is a bug that results in Nightly Benchmarks to fail pushing new results to the new results branch on intel/llvm:

[sycl d0defc846] [GHA] Upload compute-benchmarks results from https://github.com/intel/llvm/actions/runs/19053464326
 2 files changed, 15321 insertions(+)
 create mode 100644 data.json
 create mode 100644 results/Baseline_BMG_L0v2_20251104_003023.json
remote: error: GH006: Protected branch update failed for refs/heads/sycl.        
remote: 
remote: - Changes must be made through a pull request.        
remote: 
remote: - You're not authorized to push to this branch. Visit https://docs.github.com/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches for more information.  

This patch fixes the benchmarking workflow to properly push to the correct llvm-ci-perf-results branch.

@PatKamin PatKamin force-pushed the patkamin/fix-pushing-bench-results branch from 18d144a to 1ebf2b4 Compare November 4, 2025 08:46
@PatKamin
Copy link
Contributor Author

PatKamin commented Nov 4, 2025

Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PatKamin PatKamin marked this pull request as ready for review November 4, 2025 09:30
@PatKamin PatKamin requested a review from a team as a code owner November 4, 2025 09:30
@PatKamin PatKamin force-pushed the patkamin/fix-pushing-bench-results branch from 1ebf2b4 to 8d3aea8 Compare November 4, 2025 09:33
@PatKamin
Copy link
Contributor Author

PatKamin commented Nov 4, 2025

@intel/dpcpp-devops-reviewers, please review. Here is the proper test run for these changes: https://github.com/intel/llvm/actions/runs/19062984825

@lukaszstolarczuk
Copy link
Contributor

@sarnex, can you please take a look a this - we need it after merging #20333

@sarnex
Copy link
Contributor

sarnex commented Nov 4, 2025

@lukaszstolarczuk Done, can I merge or is the Benchmark CI failure related to this PR?

@uditagarwal97
Copy link
Contributor

uditagarwal97 commented Nov 4, 2025

This patch fixes the benchmarking workflow to properly push to the correct llvm-ci-perf-results branch

This doesn't make sense to me. Why are we still pushing to branch in intel/llvm-ci-perf-results? instead of pushing to sycl-benchmark-ci-results branch of intel/llvm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants