[UR] Fix warnings in appendKernelLaunchWithArgsExpNew() #20543
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Fix following warnings in appendKernelLaunchWithArgsExpNew(): warning: cast from type ‘X’ to type ‘void*’ casts away qualifiers [-Wcast-qual] Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
kswiecicki
reviewed
Nov 4, 2025
| case UR_EXP_KERNEL_ARG_TYPE_VALUE: | ||
| hKernel->kernelArgs[argIndex] = (void *)pArgs[argIndex].value.value; | ||
| hKernel->kernelArgs[argIndex] = | ||
| const_cast<void *>(pArgs[argIndex].value.value); |
There was a problem hiding this comment.
It's weird that we have to remove the const qualifier, the arg types in the spec should reflect params accepted by the underlying backend (in this case only L0, and it accepts void **). Perhaps we could remove const keywords from the spec? @pbalcer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following warnings in appendKernelLaunchWithArgsExpNew():