-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][CUDA] Implemented sampled_image_cuda.cl #1972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
nyalloc
wants to merge
1
commit into
intel:sycl
from
nyalloc:stuart/CodeGenOpenCL/sampled_image_cuda
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// RUN: %clang_cc1 %s -triple nvptx64-nvidia-cuda -O0 -emit-llvm -o - | FileCheck %s | ||
|
||
__attribute__((overloadable)) void my_read_image(__ocl_sampled_image1d_ro_t img_ro); | ||
|
||
__attribute__((overloadable)) __ocl_sampled_image1d_ro_t __spirv_SampledImage(read_only image1d_t img_wo, sampler_t sampl); | ||
|
||
void test_read_image(__ocl_sampled_image1d_ro_t img_ro, read_only image1d_t img_wo, sampler_t sampl) { | ||
|
||
// CHECK: call void @_Z13my_read_image32__spirv_SampledImage__image1d_ro(i64 %{{[a-zA-Z0-9]+}}, i32 %{{[a-zA-Z0-9]+}}) | ||
my_read_image(img_ro); | ||
// CHECK: call { i64, i32 } @_Z20__spirv_SampledImage14ocl_image1d_ro11ocl_sampler(i64 %{{[a-zA-Z0-9]+}}, i32 %{{[a-zA-Z0-9]+}}) | ||
__ocl_sampled_image1d_ro_t s_imag = __spirv_SampledImage(img_wo, sampl); | ||
// CHECK: call void @_Z13my_read_image32__spirv_SampledImage__image1d_ro(i64 %{{[a-zA-Z0-9]+}}, i32 %{{[a-zA-Z0-9]+}}) | ||
my_read_image(s_imag); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that CodeGenOpenCL test is a right place for such test...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't understand how you addressed @Fznamznon's question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries. It was only marked WIP because it wasn't passing the clang format check. I've resolved that now and removed the WIP status.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @Naghasan can provide some insight into this.