[CI][Benchmarks] Benches OS setup guide #19577
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatKamin
force-pushed
the
perf-setup-readme
branch
from
10c9baa to
045e36d
Compare
pbalcer
reviewed
Jul 24, 2025
|
|
||
| ## Overview | ||
|
|
||
| Performance benchmarking requires a stable and optimized system environment to produce reliable and reproducible results. This guide covers essential system tuning steps for reducing run-to-run variance in benchmark results and enabling consistent results across different runs. |
There was a problem hiding this comment.
Suggested change
| Performance benchmarking requires a stable and optimized system environment to produce reliable and reproducible results. This guide covers essential system tuning steps for reducing run-to-run variance in benchmark results and enabling consistent results across different runs. | |
| Performance benchmarking requires a stable and optimized system environment to produce reliable and reproducible results. This guide covers essential system tuning steps for reducing run-to-run variance in benchmark results. |
Comment on lines
23
to
33
| Add the following to `/etc/default/grub` in `GRUB_CMDLINE_LINUX`: | ||
|
|
||
| ```bash | ||
| # Disable CPU frequency scaling | ||
| intel_pstate=disable | ||
|
|
||
| # Isolate CPUs for benchmark workloads (example: reserve cores 2-7), preventing other processes | ||
| # from using them. | ||
| isolcpus=2-7 | ||
|
|
||
| # Set CPU governor to performance | ||
| sudo cpupower frequency-set --governor performance | ||
| # Apply changes to system | ||
| sudo sysctl --system | ||
|
|
||
| # Check current governor | ||
| sudo cpupower frequency-info | ||
|
|
||
| # Example complete line: | ||
| GRUB_CMDLINE_LINUX="intel_pstate=disable isolcpus=2-7" | ||
| ``` |
There was a problem hiding this comment.
This is... malformated? You can't run commands as part of GRUB_CMDLINE_LINUX.
There was a problem hiding this comment.
I've fixed formatting so it is clear what are the actual commands to paste in a terminal
| sudo update-grub | ||
| sudo reboot | ||
| ``` | ||
|
|
There was a problem hiding this comment.
It would be useful to have info on how to make these settings survive restarts. We use a systemd service in ci.
PatKamin
force-pushed
the
perf-setup-readme
branch
from
045e36d to
444e624
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://github.com/PatKamin/llvm/blob/perf-setup-readme/devops/scripts/benchmarks/PERFORMANCE_TUNING.md