Skip to content

Conversation

iburyl
Copy link
Contributor

@iburyl iburyl commented Jun 22, 2020

This second patch finishes the implementation of SYCL_INTEL_accessor_simplification extension.

It adds:

@iburyl iburyl requested a review from a team as a code owner June 22, 2020 14:15
@iburyl iburyl requested a review from sergey-semenov June 22, 2020 14:15
iburylov added 2 commits June 22, 2020 17:36
Signed-off-by: iburylov <[email protected]>
Signed-off-by: iburylov <[email protected]>
@iburyl iburyl added the spec extension All issues/PRs related to extensions specifications label Jun 22, 2020
@iburyl
Copy link
Contributor Author

iburyl commented Jun 23, 2020

@bader
Do you agree with such test decomposition?

I made two separate groups of tests, with focus on testing correct deduction for each available constructor:

  • for host accessors
  • for device accessors.

Each of them is independently run for:

  • accessors constructors interfaces and
  • buffer get_[host_]access interface.

Other cases, such as working, when wrapped into classes, or when id is passed to operator[], or when buffer has custom allocator etc. are left to original test, which is no longer focusing on deduction rules.

sergey-semenov
sergey-semenov previously approved these changes Jun 23, 2020
Copy link
Contributor

@sergey-semenov sergey-semenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM except for a minor comment

sergey-semenov
sergey-semenov previously approved these changes Jun 23, 2020
Signed-off-by: iburylov <[email protected]>
@bader bader merged commit af792cb into intel:sycl Jun 25, 2020
@iburyl iburyl deleted the get_host_access branch June 25, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec extension All issues/PRs related to extensions specifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants