Skip to content

[DeviceSanitizer] bugfix for buffer logger type error #19009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025

Conversation

yingcong-wu
Copy link
Contributor

@yingcong-wu yingcong-wu commented Jun 17, 2025

Buffer impl use char* pointer for Ptr and HostPtr, but that will confuse the logger and make it consider those as string and try to print them as string, which will result in SEGV.

@yingcong-wu yingcong-wu requested a review from a team as a code owner June 17, 2025 07:52
@yingcong-wu yingcong-wu changed the title fix [DeviceSanitizer] bugfix for buffer logger type error Jun 17, 2025
@yingcong-wu yingcong-wu requested a review from a team June 17, 2025 07:53
@pbalcer
Copy link
Contributor

pbalcer commented Jun 17, 2025

Buffer impl use char* pointer for Ptr and HostPtr, but that will confuse the logger and make it consider those as string and try to print them as string, which will result in SEGV.

we should probably be using uint8_t instead of char if something is not a c-style string.

@yingcong-wu
Copy link
Contributor Author

yingcong-wu commented Jun 17, 2025

Buffer impl use char* pointer for Ptr and HostPtr, but that will confuse the logger and make it consider those as string and try to print them as string, which will result in SEGV.

we should probably be using uint8_t instead of char if something is not a c-style string.

That is a good idea. I will update this PR with a TODO.

@yingcong-wu
Copy link
Contributor Author

Hi @intel/llvm-gatekeepers , the CI failure is not related and still fails for multiple rerun. I have created #19033 to track it. Could you please help merge this patch? Thanks.

@uditagarwal97
Copy link
Contributor

Hi @intel/llvm-gatekeepers , the CI failure is not related and still fails for multiple rerun. I have created #19033 to track it. Could you please help merge this patch? Thanks.

Yes, the CUDA failure is unrelated, I see the same failure on other PRs as well. Thanks for creating a ticket.

@uditagarwal97 uditagarwal97 merged commit 5e2d619 into intel:sycl Jun 18, 2025
69 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants