-
Notifications
You must be signed in to change notification settings - Fork 794
Event pool cache leak fix #18325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Event pool cache leak fix #18325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a073c69 to
00e307e
Compare
d778fae to
52807ee
Compare
52807ee to
4da489c
Compare
Addresses event pool leak when SYCL_PI_LEVEL_ZERO_DISABLE_EVENTS_CACHING is set. Improper cleanup in getFreeSlotInExistingOrNewPool. Signed-off-by: Zhang, Winston <[email protected]>
7d460d3 to
fc37272
Compare
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
nrspruit
approved these changes
Jul 29, 2025
Contributor
nrspruit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
|
@intel/llvm-gatekeepers , please merge when available. |
Contributor
|
No |
Contributor
|
I added the tag myself when merging. For tests I leave that to the reviewers. |
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Sep 30, 2025
addresses event pool leak when SYCL_PI_LEVEL_ZERO_DISABLE_EVENTS_CACHING is set to 1 --------- Signed-off-by: Zhang, Winston <[email protected]>
AlexeySachkov
added a commit
that referenced
this pull request
Oct 27, 2025
This is a joint cherry-pick of #18325 and #19827 --- [UR][L0] Event pool cache leak fix (#18325) addresses event pool leak when SYCL_PI_LEVEL_ZERO_DISABLE_EVENTS_CACHING is set to 1 --- [UR][L0] Event cleanup in urEnqueueKernelLaunch (#19827) When using internal events we do not clean up after execution. In the case of repeated call to urEnqueueKernelLaunch we eventually return UR_RESULT_ERROR_OUT_OF_RESOURCES. --------- Patch-by: Zhang, Winston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses event pool leak when SYCL_PI_LEVEL_ZERO_DISABLE_EVENTS_CACHING is set to 1