[SYCL][NFC] SYCL RT CMakeLists cleanup [3/N] #17413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidated all common (i.e. non-conditional) include directories settings for SYCL RT build in a single place.
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| target_link_libraries(${LIB_OBJ_NAME} | ||
| PRIVATE | ||
| UnifiedRuntime-Headers | ||
| UnifiedRuntimeCommon |
There was a problem hiding this comment.
could you please clarify why UnifiedRuntimeCommon is removed in new version?
There was a problem hiding this comment.
Two reasons:
- (main) it is not clear why SYCL RT should ever be linked with some "common" UR library - that thing seems to store some shared UR utilities which are used within UR, but not a part of the UR public interface. Tagging @intel/unified-runtime-reviewers to correct me if I'm wrong
- (secondary) object libraries are newer linked with anything, so the only reason to "link" something is to use
INTERFACElibraries to get include paths and in [SYCL][NFC] SYCL RT CMakeLists cleanup [2/N] #17388 we seems to have an agreement that "common" UR headers should not be in use by SYCL RT
There was a problem hiding this comment.
yeah I don't think anything in sycl should be using the stuff in UR common, if anything from common is used externally the fix will be to make a public interface for it
There was a problem hiding this comment.
great, thanks for the confirmation!
KseniyaTikhomirova
approved these changes
Mar 12, 2025
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidated all common (i.e. non-conditional) include directories settings for SYCL RT build in a single place.