[SYCLCompat] Fix compare_mask implementations and test
#16768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `compare_mask` and `unordered_compare_mask` implementations were placing the results of the comparison operations in the wrong 2-byte segments of the 4-byte output. The `math_compare.cpp` test has also been fixed, where the "expected" results were previously incorrect, they now reflect the values returned by the corresponding CUDA math functions.
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
JackAKirk
approved these changes
Jan 24, 2025
Contributor
Author
|
@intel/llvm-gatekeepers I believe this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
compare_maskandunordered_compare_maskimplementations were placing the results of the comparison operations in the wrong 2-byte segments of the 4-byte output.The
math_compare.cpptest has also been fixed, where the "expected" results were previously incorrect, they now reflect the values returned by the corresponding CUDA math functions.