[SYCL] Emit error when get_backend_info is used under _GLIBCXX_USE_CXX11_ABI=0
#16272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_CXX11_ABI=0` It doesn't seem that the interfaces match the spec, so it's highly likely that these methods will be deprecated/removed anyway, so there is little point in fixing them to work in `_GLIBCXX_USE_CXX11_ABI=0` mode. On the other hand, using `_GLIBCXX_USE_CXX11_ABI=0` causes segmentation fault crashes due to ABI mismatches in runtime, so emitting compile-time error is a better thing to do here.
aelovikov-intel
requested review from
uditagarwal97,
HPS-1,
AlexeySachkov and
gmlueck
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Ping @uditagarwal97 (assigned reviewer). Other reviewers were added as a "FYI". |
AlexeySachkov
approved these changes
Dec 6, 2024
HPS-1
approved these changes
Dec 6, 2024
sarnex
pushed a commit
that referenced
this pull request
Jan 23, 2025
The `get_backend_info()` functions implemented in #12906 are returning some info descriptors that are not backend-specific info descriptors but SYCL core info descriptors. This leads to problems as described in #16272 . Therefore, its current implementations are being deprecated, and removed under the `__INTEL_PREVIEW_BREAKING_CHANGES` flag. --------- Signed-off-by: Hu, Peisen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't seem that the interfaces match the spec, so it's highly likely that these methods will be deprecated/removed anyway, so there is little point in fixing them to work in
_GLIBCXX_USE_CXX11_ABI=0mode.On the other hand, using
_GLIBCXX_USE_CXX11_ABI=0causes segmentation fault crashes due to ABI mismatches in runtime, so emitting compile-time error is a better thing to do here.