Skip to content

Conversation

bjoernknafla
Copy link
Contributor

Fix some lit tests failing for CUDA by providing the -fsycl-targets
parameter.

Mark LIT tests failing due to features unsupported by CUDA as
UNSUPPORTED instead of XFAIL.

Signed-off-by: Bjoern Knafla [email protected]

@bjoernknafla bjoernknafla requested a review from a team as a code owner April 30, 2020 14:56
@bjoernknafla bjoernknafla requested a review from v-klochkov April 30, 2020 14:56
romanovvlad
romanovvlad previously approved these changes Apr 30, 2020
Copy link
Contributor

@romanovvlad romanovvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to start testing

Copy link
Contributor

@romanovvlad romanovvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Fix some lit tests failing for CUDA by providing the -fsycl-targets
parameter.

Mark LIT tests failing due to features unsupported by CUDA as
UNSUPPORTED instead of XFAIL.

Signed-off-by: Bjoern Knafla <[email protected]>
@bjoernknafla bjoernknafla force-pushed the bjoern/triage-and-clean-lit-for-cuda branch from ccfb2bb to c2bb96b Compare April 30, 2020 15:12
@bader
Copy link
Contributor

bader commented Apr 30, 2020

FYI: we temporally disable validation on CUDA - will be back next week.

@bader bader added the cuda CUDA back-end label Apr 30, 2020
@bjoernknafla bjoernknafla requested a review from v-klochkov May 1, 2020 15:11
@bader bader merged commit bd5f71b into intel:sycl May 2, 2020
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request May 6, 2020
…_docs

* origin/sycl: (6482 commits)
  [SYCL][NFC] Clean formatting in Markdown documents (intel#1635)
  [SYCL][Doc] Remove obsolete parens from README (intel#1637)
  [SYCL] Fix failing ABI tests when LLVM_LIBDIR_SUFFIX is set (intel#1605)
  [SYCL] Fix warnings in libdevice (intel#1630)
  [SYCL][CUDA] Triage and clean LIT (intel#1620)
  [SYCL][NFC] Fix GCC 8 compilation warnings (intel#1631)
  [SYCL] Minor fixes in LowerWGScope
  [SYCL] PI: correct default interoperability plugin selection
  [SYCL] Add faster reduction implementations using atomic or/and intel::reduce() (intel#1615)
  [SYCL] Add sycl-ls utility for listing devices discovered/selected by SYCL RT (intel#1575)
  [SYCL] Fix getDeviceFromHandler declarations (intel#1626)
  [SPIR-V] Correct/improve declaration of SPIR-V builtins (intel#1519)
  [SYCL][USM] Improve USM allocator test and fix improper behavior. (intel#1538)
  [SYCL] Fix failing ABI LITs (intel#1622)
  [SYCL] Add support for MSVC internal math functions in device library (intel#1441)
  [SYCL] Add runtime library versioning (intel#1604)
  [SYCL] Check weak symbols in ABI dumps (intel#1609)
  [NFC][SYCL] Improve kernel metadata test (intel#1610)
  Revert "[SYCL] XFAIL LIT test due to duplicate diagnostic" (intel#1460)
  [SYCL] Move the reduction command group funcs out of handler.hpp (intel#1602)
  ...
@bjoernknafla bjoernknafla deleted the bjoern/triage-and-clean-lit-for-cuda branch May 6, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda CUDA back-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants