[SYCL][UR] Use static cast instead of ur::cast #14830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have done so. Thanks @omarahmed1111 |
npmiller
reviewed
Aug 6, 2024
added 3 commits
August 6, 2024 10:53
UR cast is using reinterpret cast under the hood, which was failing for an unsigned long being cast to an unsigned long long. This is probably a compiler bug but this works around the issue for now.
|
ping @intel/llvm-reviewers-runtime @bso-intel this patch is small and important as it fixes the oneMKL build for CUDA and HIP |
dm-vodopyanov
previously approved these changes
Aug 6, 2024
dm-vodopyanov
changed the title
KseniyaTikhomirova
approved these changes
Aug 6, 2024
|
Thanks @KseniyaTikhomirova . Ping @intel/llvm-gatekeepers this can be merged. |
|
Unlikely HIP is related, merging now. |
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 26, 2024
UR cast is using reinterpret cast under the hood, which was failing for an unsigned long being cast to an unsigned long long. From the C++ spec: > An expression of integral, enumeration, pointer, or pointer-to-member type can be converted to its own type. The resulting value is the same as the value of expression. Since `unsigned long` is not the same type as `unsigned long long`, the `reinterpret_cast` fails. Ping @aarongreig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UR cast is using reinterpret cast under the hood, which was failing for an
unsigned long being cast to an unsigned long long. From the C++ spec:
Since
unsigned longis not the same type asunsigned long long, thereinterpret_castfails.Ping @aarongreig