Skip to content

[SYCL] Fix WA for ocl query of CL_DEVICE_PROFILE #13584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

KseniyaTikhomirova
Copy link
Contributor

@KseniyaTikhomirova KseniyaTikhomirova commented Apr 29, 2024

Improves kernel_compiler WA for CL_DEVICE_PROFILE query.
Currently ocl query returns some extra symbols we want to eliminate from final result returned to user.
Removes all special symbols now. To be removed once ocl query is fixed.

Signed-off-by: Tikhomirova, Kseniya <[email protected]>
@KseniyaTikhomirova KseniyaTikhomirova marked this pull request as ready for review April 29, 2024 14:42
@KseniyaTikhomirova KseniyaTikhomirova requested a review from a team as a code owner April 29, 2024 14:42
// Fails with opencl and level_zero on linux, enable when fixed.
// XFAIL: opencl || (linux && level_zero)
// Fails with level_zero on linux, enable when fixed.
// XFAIL: (linux && level_zero)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this can be removed. It was added when the driver change triggered new failures ( #13547 )

Your new WA should mean that the test should pass everywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cperkinsintel do we want to proceed with this WA update? it will hide the problem with opencl reporting, not solve it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed XFAIL here 2833f9f

Signed-off-by: Tikhomirova, Kseniya <[email protected]>
@KseniyaTikhomirova
Copy link
Contributor Author

@intel/llvm-gatekeepers hi, this PR is ready for merge. Thanks

@ldrumm
Copy link
Contributor

ldrumm commented Apr 30, 2024

Please make future developers' lives easier by providing a useful commit message. As it is, I have no idea of the history or intent of this patch

@KseniyaTikhomirova KseniyaTikhomirova changed the title [SYCL] Fix WA for ocl query of profile [SYCL] Fix WA for ocl query of CL_DEVICE_PROFILE Apr 30, 2024
@KseniyaTikhomirova
Copy link
Contributor Author

Please make future developers' lives easier by providing a useful commit message. As it is, I have no idea of the history or intent of this patch

done.

@ldrumm ldrumm merged commit 4f5a5f0 into intel:sycl Apr 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants