-
Notifications
You must be signed in to change notification settings - Fork 768
[SYCL] Fix WA for ocl query of CL_DEVICE_PROFILE #13584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
// Fails with opencl and level_zero on linux, enable when fixed. | ||
// XFAIL: opencl || (linux && level_zero) | ||
// Fails with level_zero on linux, enable when fixed. | ||
// XFAIL: (linux && level_zero) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure this can be removed. It was added when the driver change triggered new failures ( #13547 )
Your new WA should mean that the test should pass everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cperkinsintel do we want to proceed with this WA update? it will hide the problem with opencl reporting, not solve it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed XFAIL here 2833f9f
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
@intel/llvm-gatekeepers hi, this PR is ready for merge. Thanks |
Please make future developers' lives easier by providing a useful commit message. As it is, I have no idea of the history or intent of this patch |
done. |
Improves kernel_compiler WA for CL_DEVICE_PROFILE query.
Currently ocl query returns some extra symbols we want to eliminate from final result returned to user.
Removes all special symbols now. To be removed once ocl query is fixed.