Skip to content

[SYCL] Remove buffer.hpp's dependency on context.hpp/event.hpp #13497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2024
Merged

[SYCL] Remove buffer.hpp's dependency on context.hpp/event.hpp #13497

merged 1 commit into from
Jul 3, 2024

Conversation

aelovikov-intel
Copy link
Contributor

No description provided.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner April 19, 2024 17:21
@aelovikov-intel
Copy link
Contributor Author

This depends on #13211, please review second commit only.

againull
againull reviewed Apr 19, 2024
View reviewed changes
Copy link
Contributor

@againull againull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ABI br

sycl/test/abi/sycl_symbols_linux.dump Outdated
@@ -3246,13 +3246,13 @@ _ZN4sycl3_V16detail12buffer_plainC1EPKvmmRKNS0_13property_listESt10unique_ptrINS
_ZN4sycl3_V16detail12buffer_plainC1EPvmmRKNS0_13property_listESt10unique_ptrINS1_19SYCLMemObjAllocatorESt14default_deleteIS8_EE
_ZN4sycl3_V16detail12buffer_plainC1ERKSt10shared_ptrIKvEmmRKNS0_13property_listESt10unique_ptrINS1_19SYCLMemObjAllocatorESt14default_deleteISC_EEb
_ZN4sycl3_V16detail12buffer_plainC1ERKSt8functionIFvPvEEmmRKNS0_13property_listESt10unique_ptrINS1_19SYCLMemObjAllocatorESt14default_deleteISD_EEb
_ZN4sycl3_V16detail12buffer_plainC1EmNS0_7contextESt10unique_ptrINS1_19SYCLMemObjAllocatorESt14default_deleteIS5_EEbNS0_5eventE
_ZN4sycl3_V16detail12buffer_plainC1EmRNS0_7contextESt10unique_ptrINS1_19SYCLMemObjAllocatorESt14default_deleteIS6_EEbRNS0_5eventE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ABI breaking change, right? Should we wait for breaking window?

@aelovikov-intel aelovikov-intel marked this pull request as draft April 19, 2024 18:14
@aelovikov-intel aelovikov-intel added the abi-break change that's breaking abi and waiting for the next window to be able to merge label Apr 19, 2024
@aelovikov-intel aelovikov-intel mentioned this pull request Apr 19, 2024
Merged
@aelovikov-intel aelovikov-intel force-pushed the buffer-context-event-dep branch from e0d7fe1 to b8b1859 Compare April 19, 2024 21:07
@aelovikov-intel aelovikov-intel force-pushed the buffer-context-event-dep branch from b8b1859 to 8ae330e Compare April 19, 2024 21:08
@aelovikov-intel aelovikov-intel changed the title [SYCL] Remove buffer's dependency on context/event [SYCL][ABI Break] Remove buffer's dependency on context/event Apr 19, 2024
aelovikov-intel added a commit to aelovikov-intel/llvm that referenced this pull request Apr 23, 2024
@aelovikov-intel
[SYCL] Reduce buffer.hpp dependency on half/bfloat16
c389199 
Can't eliminate it because that requires
intel#13497 that is awaiting ABI breaking
window.
aelovikov-intel added a commit that referenced this pull request Apr 24, 2024
@aelovikov-intel
[SYCL] Reduce buffer.hpp dependency on half/bfloat16 (#13498)
4349388 
Can't eliminate it because that requires
#13497 that is awaiting ABI breaking
window.
@aelovikov-intel aelovikov-intel force-pushed the buffer-context-event-dep branch from 8ae330e to 9e536f4 Compare May 23, 2024 20:49
@aelovikov-intel aelovikov-intel force-pushed the buffer-context-event-dep branch from 9e536f4 to fa68fd8 Compare May 28, 2024 17:40
@aelovikov-intel aelovikov-intel force-pushed the buffer-context-event-dep branch from fa68fd8 to e5ac6d3 Compare July 1, 2024 17:46
@aelovikov-intel aelovikov-intel force-pushed the buffer-context-event-dep branch from e5ac6d3 to 37ef642 Compare July 1, 2024 17:57
@aelovikov-intel aelovikov-intel changed the title [SYCL][ABI Break] Remove buffer's dependency on context/event [SYCL] Remove buffer.hpp's dependency on context.hpp/event.hpp Jul 1, 2024
@aelovikov-intel aelovikov-intel force-pushed the buffer-context-event-dep branch from 37ef642 to 5803df7 Compare July 1, 2024 18:12
@aelovikov-intel aelovikov-intel force-pushed the buffer-context-event-dep branch from 5803df7 to 8230f92 Compare July 1, 2024 18:29
@aelovikov-intel aelovikov-intel force-pushed the buffer-context-event-dep branch from 8230f92 to f67eb38 Compare July 2, 2024 20:24
@aelovikov-intel aelovikov-intel marked this pull request as ready for review July 2, 2024 23:50
@aelovikov-intel aelovikov-intel requested a review from againull July 2, 2024 23:50
@aelovikov-intel aelovikov-intel merged commit 17b9836 into intel:sycl Jul 3, 2024
@aelovikov-intel aelovikov-intel deleted the buffer-context-event-dep branch July 3, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@againull againull againull approved these changes

Assignees
No one assigned
Labels
abi-break change that's breaking abi and waiting for the next window to be able to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aelovikov-intel @againull