Skip to content

Commit 4349388

Browse files
[SYCL] Reduce buffer.hpp dependency on half/bfloat16 (#13498)
Can't eliminate it because that requires #13497 that is awaiting ABI breaking window.
1 parent f017487 commit 4349388

File tree

8 files changed

+27
-20
lines changed

8 files changed

+27
-20
lines changed

sycl/include/CL/__spirv/spirv_ops.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
#include <stddef.h> // for size_t
1616
#include <stdint.h> // for uint32_t
17+
#include <type_traits>
1718

1819
// Convergent attribute
1920
#ifdef __SYCL_DEVICE_ONLY__

sycl/include/CL/__spirv/spirv_types.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#pragma once
1010

1111
#include <sycl/detail/defines.hpp> // for __has_builtin
12-
#include <sycl/half_type.hpp> // for half
1312

1413
#include <cstddef> // for size_t
1514
#include <cstdint> // for uint32_t

sycl/include/sycl/detail/generic_type_lists.hpp

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@
1010

1111
#include <sycl/access/access.hpp> // for address_space
1212
#include <sycl/detail/type_list.hpp> // for type_list, address_space_list
13-
#include <sycl/half_type.hpp> // for half
14-
15-
#include <sycl/ext/oneapi/bfloat16.hpp> // bfloat16
1613

1714
#include <cstddef> // for byte, size_t
1815
#include <type_traits> // for conditional_t, is_signed_v, is_...
@@ -26,6 +23,16 @@ inline namespace _V1 {
2623
template <typename T, int N> class vec;
2724
template <typename Type, std::size_t NumElements> class marray;
2825

26+
namespace detail {
27+
namespace half_impl {
28+
class half;
29+
}
30+
} // namespace detail
31+
using half = detail::half_impl::half;
32+
33+
namespace ext::oneapi {
34+
class bfloat16;
35+
}
2936
namespace detail {
3037
namespace gtl {
3138
// floating point types

sycl/include/sycl/detail/type_traits.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
#include <sycl/access/access.hpp> // for decorated, address_space
1212
#include <sycl/detail/generic_type_lists.hpp> // for vec, marray, integer_list
1313
#include <sycl/detail/type_list.hpp> // for is_contained, find_twi...
14-
#include <sycl/half_type.hpp> // for half
1514

1615
#include <array> // for array
1716
#include <cstddef> // for size_t

sycl/source/detail/plugin_printers.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
#pragma once
1212

13+
#include <sycl/detail/iostream_proxy.hpp>
1314
#include <sycl/detail/pi.hpp>
1415

1516
#include <type_traits>

sycl/test/include_deps/sycl_accessor.hpp.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@
1010
// CHECK-NEXT: CL/__spirv/spirv_ops.hpp
1111
// CHECK-NEXT: CL/__spirv/spirv_types.hpp
1212
// CHECK-NEXT: detail/defines.hpp
13+
// CHECK-NEXT: detail/export.hpp
14+
// CHECK-NEXT: aliases.hpp
1315
// CHECK-NEXT: half_type.hpp
1416
// CHECK-NEXT: bit_cast.hpp
15-
// CHECK-NEXT: detail/export.hpp
1617
// CHECK-NEXT: detail/iostream_proxy.hpp
1718
// CHECK-NEXT: detail/vector_traits.hpp
1819
// CHECK-NEXT: aspects.hpp
1920
// CHECK-NEXT: info/aspects.def
2021
// CHECK-NEXT: info/aspects_deprecated.def
21-
// CHECK-NEXT: aliases.hpp
2222
// CHECK-NEXT: atomic.hpp
2323
// CHECK-NEXT: detail/helpers.hpp
2424
// CHECK-NEXT: detail/pi.hpp
@@ -60,7 +60,6 @@
6060
// CHECK-NEXT: detail/boost/mp11/detail/mp_map_find.hpp
6161
// CHECK-NEXT: detail/boost/mp11/detail/mp_with_index.hpp
6262
// CHECK-NEXT: detail/boost/mp11/integer_sequence.hpp
63-
// CHECK-NEXT: ext/oneapi/bfloat16.hpp
6463
// CHECK-NEXT: buffer.hpp
6564
// CHECK-NEXT: context.hpp
6665
// CHECK-NEXT: async_handler.hpp
@@ -78,6 +77,7 @@
7877
// CHECK-NEXT: info/info_desc.hpp
7978
// CHECK-NEXT: ext/oneapi/experimental/device_architecture.hpp
8079
// CHECK-NEXT: ext/oneapi/matrix/query-types.hpp
80+
// CHECK-NEXT: ext/oneapi/bfloat16.hpp
8181
// CHECK-NEXT: ext/oneapi/matrix/matrix-unified-utils.hpp
8282
// CHECK-NEXT: info/platform_traits.def
8383
// CHECK-NEXT: info/context_traits.def

sycl/test/include_deps/sycl_buffer.hpp.cpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,7 @@
1010
// CHECK-NEXT: CL/__spirv/spirv_ops.hpp
1111
// CHECK-NEXT: CL/__spirv/spirv_types.hpp
1212
// CHECK-NEXT: detail/defines.hpp
13-
// CHECK-NEXT: half_type.hpp
14-
// CHECK-NEXT: bit_cast.hpp
1513
// CHECK-NEXT: detail/export.hpp
16-
// CHECK-NEXT: detail/iostream_proxy.hpp
17-
// CHECK-NEXT: detail/vector_traits.hpp
18-
// CHECK-NEXT: aspects.hpp
19-
// CHECK-NEXT: info/aspects.def
20-
// CHECK-NEXT: info/aspects_deprecated.def
2114
// CHECK-NEXT: backend_types.hpp
2215
// CHECK-NEXT: context.hpp
2316
// CHECK-NEXT: async_handler.hpp
@@ -30,6 +23,9 @@
3023
// CHECK-NEXT: memory_enums.hpp
3124
// CHECK-NEXT: CL/__spirv/spirv_vars.hpp
3225
// CHECK-NEXT: detail/info_desc_helpers.hpp
26+
// CHECK-NEXT: aspects.hpp
27+
// CHECK-NEXT: info/aspects.def
28+
// CHECK-NEXT: info/aspects_deprecated.def
3329
// CHECK-NEXT: id.hpp
3430
// CHECK-NEXT: detail/array.hpp
3531
// CHECK-NEXT: exception.hpp
@@ -39,6 +35,7 @@
3935
// CHECK-NEXT: CL/cl_platform.h
4036
// CHECK-NEXT: CL/cl_ext.h
4137
// CHECK-NEXT: detail/common.hpp
38+
// CHECK-NEXT: detail/iostream_proxy.hpp
4239
// CHECK-NEXT: range.hpp
4340
// CHECK-NEXT: info/info_desc.hpp
4441
// CHECK-NEXT: detail/type_traits.hpp
@@ -71,10 +68,13 @@
7168
// CHECK-NEXT: detail/boost/mp11/detail/mp_map_find.hpp
7269
// CHECK-NEXT: detail/boost/mp11/detail/mp_with_index.hpp
7370
// CHECK-NEXT: detail/boost/mp11/integer_sequence.hpp
74-
// CHECK-NEXT: ext/oneapi/bfloat16.hpp
75-
// CHECK-NEXT: aliases.hpp
7671
// CHECK-NEXT: ext/oneapi/experimental/device_architecture.hpp
7772
// CHECK-NEXT: ext/oneapi/matrix/query-types.hpp
73+
// CHECK-NEXT: ext/oneapi/bfloat16.hpp
74+
// CHECK-NEXT: aliases.hpp
75+
// CHECK-NEXT: half_type.hpp
76+
// CHECK-NEXT: bit_cast.hpp
77+
// CHECK-NEXT: detail/vector_traits.hpp
7878
// CHECK-NEXT: ext/oneapi/matrix/matrix-unified-utils.hpp
7979
// CHECK-NEXT: info/platform_traits.def
8080
// CHECK-NEXT: info/context_traits.def

sycl/test/include_deps/sycl_detail_core.hpp.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@
1111
// CHECK-NEXT: CL/__spirv/spirv_ops.hpp
1212
// CHECK-NEXT: CL/__spirv/spirv_types.hpp
1313
// CHECK-NEXT: detail/defines.hpp
14+
// CHECK-NEXT: detail/export.hpp
15+
// CHECK-NEXT: aliases.hpp
1416
// CHECK-NEXT: half_type.hpp
1517
// CHECK-NEXT: bit_cast.hpp
16-
// CHECK-NEXT: detail/export.hpp
1718
// CHECK-NEXT: detail/iostream_proxy.hpp
1819
// CHECK-NEXT: detail/vector_traits.hpp
1920
// CHECK-NEXT: aspects.hpp
2021
// CHECK-NEXT: info/aspects.def
2122
// CHECK-NEXT: info/aspects_deprecated.def
22-
// CHECK-NEXT: aliases.hpp
2323
// CHECK-NEXT: atomic.hpp
2424
// CHECK-NEXT: detail/helpers.hpp
2525
// CHECK-NEXT: detail/pi.hpp
@@ -61,7 +61,6 @@
6161
// CHECK-NEXT: detail/boost/mp11/detail/mp_map_find.hpp
6262
// CHECK-NEXT: detail/boost/mp11/detail/mp_with_index.hpp
6363
// CHECK-NEXT: detail/boost/mp11/integer_sequence.hpp
64-
// CHECK-NEXT: ext/oneapi/bfloat16.hpp
6564
// CHECK-NEXT: buffer.hpp
6665
// CHECK-NEXT: context.hpp
6766
// CHECK-NEXT: async_handler.hpp
@@ -79,6 +78,7 @@
7978
// CHECK-NEXT: info/info_desc.hpp
8079
// CHECK-NEXT: ext/oneapi/experimental/device_architecture.hpp
8180
// CHECK-NEXT: ext/oneapi/matrix/query-types.hpp
81+
// CHECK-NEXT: ext/oneapi/bfloat16.hpp
8282
// CHECK-NEXT: ext/oneapi/matrix/matrix-unified-utils.hpp
8383
// CHECK-NEXT: info/platform_traits.def
8484
// CHECK-NEXT: info/context_traits.def

0 commit comments

Comments
 (0)