Skip to content

[ESIMD][E2E] Enable few cases in atomic_update after gpu driver update #12639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2024
Merged

[ESIMD][E2E] Enable few cases in atomic_update after gpu driver update #12639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a931c21
[ESIMD][E2E] Enable few cases in atomic_update after gpu driver update
v-klochkov Feb 7, 2024
a38e784
Merge remote-tracking branch 'intel_llvm/sycl' into esimd_enable_atom…
v-klochkov Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions sycl/test-e2e/ESIMD/unified_memory_api/Inputs/atomic_update.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,13 +715,10 @@ bool test_int_types_and_sizes(queue q, const Config &cfg) {
q, cfg);
passed &= test_int_types<64, Op, UseMask, UseLSCFeatures, UseAcc, SignMask>(
q, cfg);
// non power of two values are supported only in newer driver.
// TODO: Enable this when the new driver reaches test infrastructure
// (v27556).
#if 0
passed &= test_int_types<12, Op, UseMask, UseLSCFeatures, UseAcc, SignMask>(q, cfg);
passed &= test_int_types<33, Op, UseMask, UseLSCFeatures, UseAcc, SignMask>(q, cfg);
#endif
passed &= test_int_types<12, Op, UseMask, UseLSCFeatures, UseAcc, SignMask>(
q, cfg);
passed &= test_int_types<33, Op, UseMask, UseLSCFeatures, UseAcc, SignMask>(
q, cfg);
}

return passed;
Expand All @@ -742,13 +739,8 @@ bool test_fp_types_and_sizes(queue q, const Config &cfg) {
passed &= test_fp_types<32, Op, UseMask, UseLSCFeatures, UseAcc>(q, cfg);
passed &= test_fp_types<64, Op, UseMask, UseLSCFeatures, UseAcc>(q, cfg);

// non power of two values are supported only in newer driver.
// TODO: Enable this when the new driver reaches test infrastructure
// (v27556).
#if 0
passed &= test_fp_types<12, Op, UseMask, UseLSCFeatures, UseAcc>(q, cfg);
passed &= test_fp_types<35, Op, UseMask, UseLSCFeatures, UseAcc>(q, cfg);
#endif
}
return passed;
}
Expand Down
22 changes: 3 additions & 19 deletions sycl/test-e2e/ESIMD/unified_memory_api/Inputs/atomic_update_slm.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,14 +612,9 @@ bool test_fp_types(queue q) {

if constexpr (Features == TestFeatures::DG2 ||
Features == TestFeatures::PVC) {
// TODO: fmin/fmax/fcmpxchg for double requires a newer GPU driver.
if constexpr (!std::is_same_v<Op<double, N>, ImplLSCFmax<double, N>> &&
!std::is_same_v<Op<double, N>, ImplLSCFmin<double, N>> &&
!std::is_same_v<Op<double, N>, ImplLSCFcmpwr<double, N>>) {
if (q.get_device().has(sycl::aspect::atomic64) &&
q.get_device().has(sycl::aspect::fp64)) {
passed &= run_test<UseAcc, double, N, Op, UseMask>(q);
}
if (q.get_device().has(sycl::aspect::atomic64) &&
q.get_device().has(sycl::aspect::fp64)) {
passed &= run_test<UseAcc, double, N, Op, UseMask>(q);
}
}
return passed;
Expand All @@ -633,7 +628,6 @@ bool test_int_types_and_sizes(queue q) {
passed &= test_int_types<2, Op, UseMask, Features, UseAcc, SignMask>(q);
passed &= test_int_types<4, Op, UseMask, Features, UseAcc, SignMask>(q);
passed &= test_int_types<8, Op, UseMask, Features, UseAcc, SignMask>(q);
// TODO: N=16 and N=32 does not pass on Gen12 with mask due to older driver.
if (UseMask && Features == TestFeatures::Generic &&
esimd_test::isGPUDriverGE(q, esimd_test::GPUDriverOS::LinuxAndWindows,
"26918", "101.4953", false)) {
Expand All @@ -645,13 +639,8 @@ bool test_int_types_and_sizes(queue q) {
if constexpr (Features == TestFeatures::DG2 ||
Features == TestFeatures::PVC) {
passed &= test_int_types<64, Op, UseMask, Features, UseAcc, SignMask>(q);
// non power of two values are supported only in newer driver.
// TODO: Enable this when the new driver reaches test infrastructure
// (v27556).
#if 0
passed &= test_int_types<12, Op, UseMask, Features, UseAcc, SignMask>(q);
passed &= test_int_types<33, Op, UseMask, Features, UseAcc, SignMask>(q);
#endif
}

return passed;
Expand All @@ -672,13 +661,8 @@ bool test_fp_types_and_sizes(queue q) {
if constexpr (Features == TestFeatures::DG2 ||
Features == TestFeatures::PVC) {
passed &= test_fp_types<64, Op, UseMask, Features, UseAcc>(q);
// non power of two values are supported only in newer driver.
// TODO: Enable this when the new driver reaches test infrastructure
// (v27556).
#if 0
passed &= test_fp_types<33, Op, UseMask, Features, UseAcc>(q);
passed &= test_fp_types<65, Op, UseMask, Features, UseAcc>(q);
#endif
}
return passed;
}
Expand Down