Skip to content

[ESIMD][E2E] Enable few cases in atomic_update after gpu driver update #12639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2024
Merged

[ESIMD][E2E] Enable few cases in atomic_update after gpu driver update #12639

merged 2 commits into from
Feb 7, 2024

Conversation

v-klochkov
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@v-klochkov v-klochkov force-pushed the esimd_enable_atomic_update_cases branch from be28ce1 to a931c21 Compare February 7, 2024 14:09
@v-klochkov v-klochkov marked this pull request as ready for review February 7, 2024 14:10
@v-klochkov v-klochkov requested a review from a team as a code owner February 7, 2024 14:10
sarnex
sarnex approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@v-klochkov
Copy link
Contributor Author

The ESIMD/aot_mixed.cpp fail is not related to other 2 E2E tests updated in this PR.
Also, ESIMD/aot_mixed.cpp is fixed here: #12650

@v-klochkov v-klochkov merged commit 5f1d98a into intel:sycl Feb 7, 2024
@v-klochkov v-klochkov deleted the esimd_enable_atomic_update_cases branch February 7, 2024 21:04
@ldrumm
Copy link
Contributor

ldrumm commented Feb 8, 2024

ESIMD/unified_memory_api/atomic_update_acc_dg2_pvc_cmpxchg.cpp seems to be broken by this patch. Could you please forward a fix or revert?

@ldrumm
Copy link
Contributor

ldrumm commented Feb 8, 2024

ESIMD/unified_memory_api/atomic_update_acc_dg2_pvc_cmpxchg.cpp includes atomic_update_acc_dg2_pvc.cpp which itself includes Inputs/atomic_update.hpp changed here

@ldrumm ldrumm mentioned this pull request Feb 8, 2024
Merged
ldrumm added a commit that referenced this pull request Feb 8, 2024
@ldrumm
Revert "[ESIMD][E2E] Enable few cases in atomic_update after gpu driv…
d69a4c2 
…er update" (#12669)

Reverts #12639

This regressed atomic_update_acc_dg2_pvc_cmpxchg.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarnex sarnex sarnex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-klochkov @ldrumm @sarnex