[SYCL] Change which constructor is gated for devices #1183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Brodman <[email protected]>
Pennycook
previously approved these changes
Feb 25, 2020
|
@jbrodman, please, ignore failure in clang-format-check job. It seems to include irrelevant changes into the validated change. |
👍 |
bader
reviewed
Feb 25, 2020
Signed-off-by: James Brodman <[email protected]>
Pennycook
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYCL 1.2.1 includes a constructor for
multi_ptrfromT*, available on both the host and device. The current implementation disables this constructor on the host to avoid conflicting definitions for constructors usingpointer_tandT*.Making this constructor available enables implicit conversions between pointer types and
multi_ptrclasses, and addresses requests such as #849.Signed-off-by: James Brodman [email protected]