[SYCL][Fusion] Avoid deferred cleanup for fusion #11598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sommerlukas
force-pushed
the
no-deferred-fusion-cleanup
branch
from
30b9898 to
e9a1dab
Compare
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
The errors on CUDA CI seems unrelated to this PR: # .---command stderr------------
# |
# | UR CUDA ERROR:
# | Value: 101
# | Name: CUDA_ERROR_INVALID_DEVICE
# | Description: invalid device ordinal
# | Function: operator()
# | Source Location: /__w/llvm/llvm/build/_deps/unified-runtime-src/source/adapters/cuda/platform.cpp:75
# |
# | terminate called after throwing an instance of 'sycl::_V1::runtime_error'
# | what(): No device of requested type available. -1 (PI_ERROR_DEVICE_NOT_FOUND)
# `-----------------------------
# error: command failed with exit status: -6 |
Contributor
Author
|
@sergey-semenov Friendly ping. |
sergey-semenov
approved these changes
Nov 29, 2023
Contributor
sergey-semenov
left a comment
sergey-semenov
left a comment
There was a problem hiding this comment.
Please, update the PR with the latest changes from the sycl branch since the test results are quite stale.
Full cleanup for fusion placeholder commands is handled by specialized scheduler entry points (`start_fusion`, `cleanUPCmdFusion`). To avoid interference with that mechanism, fusion commands should not be added to the deferred cleanup list. Signed-off-by: Lukas Sommer <[email protected]>
sommerlukas
force-pushed
the
no-deferred-fusion-cleanup
branch
from
e9a1dab to
15b02bd
Compare
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sommerlukas
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
Author
|
Updated the branch as requested by @sergey-semenov. Test failures are unrelated to this PR:
@intel/llvm-gatekeepers Can someone merge this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full cleanup for fusion placeholder commands is handled by specialized scheduler entry points (
start_fusion,cleanUPCmdFusion). To avoid interference with that mechanism, fusion commands should not be added to the deferred cleanup list.