This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Test to check dependency chain for in-order queue between usm&host tasks #1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/verify with intel/llvm#6840 |
againull
added a commit
to intel/llvm
that referenced
this pull request
Sep 22, 2022
…sks (#6840) Currently last event is not updated for usm commands, so dependency chain is incorrect if usm commands are interleaved with host tasks. Also we need to wait if the last event is associated with host task before submitting usm command. E2E test: intel/llvm-test-suite#1283
| int main() { | ||
| queue Q{property::queue::in_order()}; | ||
|
|
||
| int *X = malloc_host<int>(100, Q); |
There was a problem hiding this comment.
minor comment: could we have a constant for size instead raw value in test?
| }); | ||
| Q.wait(); | ||
|
|
||
| int Error = (Z[99] != 196) ? 1 : 0; |
There was a problem hiding this comment.
I guess it should check if host task waits till usm operation completion but could we also check the reverse case? I see that you fill X with values using host task and than overwrite it many times with usm operations but never check and result in final check is also not dependent on it.
againull
commented
Dec 1, 2022
| int main() { | ||
| queue Q{property::queue::in_order()}; | ||
|
|
||
| int *X = malloc_host<int>(100, Q); |
| }); | ||
| Q.wait(); | ||
|
|
||
| int Error = (Z[99] != 196) ? 1 : 0; |
|
@KseniyaTikhomirova please review this after addressing your concerns. |
KseniyaTikhomirova
approved these changes
Dec 13, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for intel/llvm#6840