This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[ESIMD] Add a LIT test verifying DPAS with 2 tfloat32 arguments #1180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/verify with intel/llvm#6647 |
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
force-pushed
the
esimd_dpas_tf32_nosrc0_test
branch
from
d6472c1 to
c8d4cf7
Compare
|
/verify with intel/llvm#6647 |
kbobrovs
reviewed
Aug 27, 2022
SYCL/ESIMD/dpas/dpas_tf32.cpp
Outdated
| using namespace sycl::ext::intel::experimental::esimd; | ||
|
|
||
| int main() { | ||
| queue Q; |
There was a problem hiding this comment.
why not use custom selector and exception handler as in ESIMD tests?
queue q(esimd_test::ESIMDSelector{}, esimd_test::createExceptionHandler());
There was a problem hiding this comment.
because the way how CI works, the GPU selector will be chosen anyway.
Regarding exception handler..., Ok, I'll add it.
kbobrovs
reviewed
Aug 27, 2022
SYCL/ESIMD/dpas/dpas_tf32.cpp
Outdated
| }).wait(); | ||
|
|
||
| unsigned ErrCnt = 0; | ||
| for (unsigned I = 0; I < M * N && ErrCnt < 10; ++I) { |
There was a problem hiding this comment.
Nit: this will likely give warnings on linux and suggestion to add braces
There was a problem hiding this comment.
I compiled it on Linux and no-warnings. But no problems, I added braces: 1667d58
Thank you.
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
|
/verify with intel/llvm#6647 |
kbobrovs
approved these changes
Aug 29, 2022
|
The fails on Windows are unrelated and known (there is internal tracker). |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…l#1180) * [ESIMD] Add a LIT test verifying DPAS with 2 tfloat32 arguments Signed-off-by: Vyacheslav N Klochkov <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…l/llvm-test-suite#1180) * [ESIMD] Add a LIT test verifying DPAS with 2 tfloat32 arguments Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vyacheslav N Klochkov [email protected]