This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Use 0 for generic mem_advise #1140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests attempt to do a generic mem_advise to test certain behaviour that should not be affected by the actual advice. Previously the CUDA backend wouldn't correctly handle advice 0, which was supposed to signify a reset of previously set advice. Now that the CUDA backend correctly handles this option we can return to using 0. Likewise we can PI enumerators from these tests and use 0 directly. Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
aelovikov-intel
approved these changes
Aug 9, 2022
|
Failures in ESIMD/regression/bit_shift_compilation_test.cpp are due to a desync between the test-suite and intel/llvm. They are unrelated. |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
Some tests attempt to do a generic mem_advise to test certain behaviour that should not be affected by the actual advice. Previously the CUDA backend wouldn't correctly handle advice 0, which was supposed to signify a reset of previously set advice. Now that the CUDA backend correctly handles this option we can return to using 0. Likewise we can PI enumerators from these tests and use 0 directly. Signed-off-by: Larsen, Steffen <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Some tests attempt to do a generic mem_advise to test certain behaviour that should not be affected by the actual advice. Previously the CUDA backend wouldn't correctly handle advice 0, which was supposed to signify a reset of previously set advice. Now that the CUDA backend correctly handles this option we can return to using 0. Likewise we can PI enumerators from these tests and use 0 directly. Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests attempt to do a generic mem_advise to test certain behaviour that should not be affected by the actual advice. Previously the CUDA backend wouldn't correctly handle advice 0, which was supposed to signify a reset of previously set advice. Now that the CUDA backend correctly handles this option we can return to using 0. Likewise we can remove PI enumerators from these tests and use 0 directly.