nfd: Update node-feature-rules-openshift.yaml #112

hershpa · 2023-08-22T22:31:24Z

Keep node feature rules only for SGX, QAT, and GPU.
Keep only 4xxx device IDs for QAT as we support QAT only on SPR or later platforms.
Signed-off-by: Hersh Pathak [email protected]

hershpa · 2023-08-22T22:32:14Z

@vbedida79 @mregmi @uMartinXu pls help review.

hershpa · 2023-08-22T22:55:49Z

testing completed successfully

vbedida79 · 2023-08-22T22:57:23Z

nfd/node-feature-rules-openshift.yaml

            class: {op: In, value: ["0b40"]}
        - feature: kernel.loadedmodule
          matchExpressions:
            intel_qat: {op: Exists}

-    - name: "intel.sgx"
+     - name: "intel.sgx"


a change: indentation error here

Good eye! Thanks @vbedida79

vbedida79 · 2023-08-22T23:28:51Z

Deployed it to check sgx. The node is not labelled with "intel.feature.node.kubernetes.io/sgx": "true". Assuming that this change is not present in the NFD operator on OCP 4.12 yet, we can skip this for now. Need to reconfirm later.

hershpa · 2023-08-23T06:17:15Z

Deployed it to check sgx. The node is not labelled with "intel.feature.node.kubernetes.io/sgx": "true". Assuming that this change is not present in the NFD operator on OCP 4.12 yet, we can skip this for now. Need to reconfirm later.

Got it, updated commit to keep SGX NFD rules as is for now.

mythi · 2023-08-23T14:10:03Z

Deployed it to check sgx. The node is not labelled with "intel.feature.node.kubernetes.io/sgx": "true". Assuming that this change is not present in the NFD operator on OCP 4.12 yet, we can skip this for now. Need to reconfirm later.

What is the NFD version available? Do we need to submit a ticket to get the version updated?

uMartinXu · 2023-08-23T17:28:36Z

nfd/node-feature-rules-openshift.yaml

-          matchExpressions:
-            dfl_pci: {op: Exists}
-
+      matchAny:


I prefer not to add the FPGA and IAA into the NFD if we haven't started to support them or will enable them in the coming release.

I think we can keep IAA since it will be enabled in 1.1.0 release. I agree, we can remove FPGA and DLB as well. Can we keep IAA or remove it as well?

I suggest to remove IAA, and only add what we will support.

Makes sense! :)

uMartinXu · 2023-08-23T17:31:22Z

nfd/node-feature-rules-openshift.yaml

@@ -62,7 +81,7 @@ spec:
        - feature: pci.device
          matchExpressions:
            vendor: {op: In, value: ["8086"]}
-            device: {op: In, value: ["37c8", "4940"]}


@mregmi is these the device ID for 4xxx QAT device? Can we add some HW detail about the 4xxx QAT device?

These are OK. What details you had in mind?

All the devices with 4xxx device ID should be the integrated QAT 2.0 HW on SPR or later xeon platforms. @mythi is that correct?

vbedida79 · 2023-08-23T17:52:06Z

Deployed it to check sgx. The node is not labelled with "intel.feature.node.kubernetes.io/sgx": "true". Assuming that this change is not present in the NFD operator on OCP 4.12 yet, we can skip this for now. Need to reconfirm later.

What is the NFD version available? Do we need to submit a ticket to get the version updated?

Yes OCP NFD 4.12.0-202307182142. No exact info in repo Based on some older releases its upstream v0.x.0 for ocp 4.x. So v0.12.0. This change is in v0.13.0 upstream. Submitted a ticket on RH portal for confirming.

hershpa · 2023-08-23T18:29:32Z

Thanks @vbedida79

uMartinXu · 2023-08-23T23:31:12Z

@hershpa for this PR, please only work on changing the QAT device. And in the commit log, explain the reason why we made this change. After that, I am OK to merge it. Thanks!

hershpa · 2023-08-23T23:54:59Z

Sounds good, thanks @uMartinXu for the review.

hershpa · 2023-08-24T17:04:07Z

Updated PR @uMartinXu, @vbedida79

uMartinXu · 2023-08-25T16:17:59Z

nfd/node-feature-rules-openshift.yaml

@@ -54,15 +15,15 @@ spec:
          matchExpressions:
            vendor: {op: In, value: ["8086"]}
            class: {op: In, value: ["0300", "0380"]}
-
+    


Clean up by remove the space from this line.

The PR looks good to me.

Keep node feature rules only for SGX, QAT, and GPU. Keep only 4xxx device IDs for QAT as we support QAT only on SPR or later platforms. Signed-off-by: Hersh Pathak [email protected]

vbedida79 · 2023-09-12T22:17:50Z

Deployed it to check sgx. The node is not labelled with "intel.feature.node.kubernetes.io/sgx": "true". Assuming that this change is not present in the NFD operator on OCP 4.12 yet, we can skip this for now. Need to reconfirm later.

What is the NFD version available? Do we need to submit a ticket to get the version updated?

Yes OCP NFD 4.12.0-202307182142. No exact info in repo Based on some older releases its upstream v0.x.0 for ocp 4.x. So v0.12.0. This change is in v0.13.0 upstream. Submitted a ticket on RH portal for confirming.

Confirmed from RH, this change will be in OCP 4.14.

hershpa · 2023-09-12T22:21:22Z

Thanks @vbedida79

hershpa added the nfd NFD label Aug 22, 2023

hershpa added this to the v1.0.1 milestone Aug 22, 2023

hershpa added the do-not-merge/hold Indicates that a PR should not merge since it is on hold label Aug 22, 2023

vbedida79 reviewed Aug 22, 2023

View reviewed changes

hershpa force-pushed the hershpa-patch-1 branch from 7121853 to bc91705 Compare August 22, 2023 23:03

hershpa force-pushed the hershpa-patch-1 branch from 1ecc2e1 to a7effe8 Compare August 23, 2023 06:15

hershpa removed the do-not-merge/hold Indicates that a PR should not merge since it is on hold label Aug 23, 2023

uMartinXu reviewed Aug 23, 2023

View reviewed changes

hershpa mentioned this pull request Aug 23, 2023

v1.0.1 Release Checklist #105

Closed

8 tasks

hershpa force-pushed the hershpa-patch-1 branch from fbd52fa to c28432e Compare August 24, 2023 17:03

uMartinXu reviewed Aug 25, 2023

View reviewed changes

nfd: Update node-feature-rules-openshift.yaml

c4f2047

Keep node feature rules only for SGX, QAT, and GPU. Keep only 4xxx device IDs for QAT as we support QAT only on SPR or later platforms. Signed-off-by: Hersh Pathak [email protected]

hershpa force-pushed the hershpa-patch-1 branch from c21b2df to c4f2047 Compare August 25, 2023 16:26

uMartinXu merged commit c44d529 into main Aug 25, 2023

hershpa deleted the hershpa-patch-1 branch September 8, 2023 20:56

nfd: Update node-feature-rules-openshift.yaml #112

nfd: Update node-feature-rules-openshift.yaml #112

Uh oh!

Conversation

hershpa commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hershpa commented Aug 22, 2023

Uh oh!

hershpa commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vbedida79 commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hershpa commented Aug 23, 2023

Uh oh!

mythi commented Aug 23, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vbedida79 commented Aug 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hershpa commented Aug 23, 2023

Uh oh!

uMartinXu commented Aug 23, 2023

Uh oh!

hershpa commented Aug 23, 2023

Uh oh!

hershpa commented Aug 24, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vbedida79 commented Sep 12, 2023

Uh oh!

hershpa commented Sep 12, 2023

Uh oh!

Uh oh!

hershpa commented Aug 22, 2023 •

edited

Loading

hershpa commented Aug 22, 2023 •

edited

Loading

vbedida79 commented Aug 22, 2023 •

edited

Loading

vbedida79 commented Aug 23, 2023 •

edited

Loading