qat: Add AppArmor unconfided anntotation configurability in the operator

[ozhuraki]

Fixes: #1575

[codecov-commenter]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ff41eb8) 51.89% compared to head (d4c9a75) 51.91%.
Report is 2 commits behind head on main.

❗ Current head d4c9a75 differs from pull request most recent head ab0e8bc. Consider uploading reports for the commit ab0e8bc to get more accurate results

Files	Patch %	Lines
pkg/controllers/qat/controller.go	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1591      +/-   ##
==========================================
+ Coverage   51.89%   51.91%   +0.02%     
==========================================
  Files          42       42              
  Lines        4916     4914       -2     
==========================================
  Hits         2551     2551              
+ Misses       2215     2213       -2     
  Partials      150      150              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mythi]

thanks @ozhuraki for getting this started! two comments

[mythi]

forgot to add 'request changes'

[tkatila]

I'd avoid having qat specific args in the operator cli. @mythi 's proposal for having the annotation as default and then allowing user to change it by modifying the CR seems like a better option.

[ozhuraki]

@tkatila @mythi

I'd avoid having qat specific args in the operator cli. @mythi 's proposal for having the annotation as default and then allowing user to change it by modifying the CR seems like a better option.

Thanks, preliminary makes sense, will take a look at this option.

[ozhuraki]

@tkatila @mythi

I haven't found a good way to provide a kustomization without moving / duplicating the sample CR deployment (deployments/operator/samples/deviceplugin_v1_qatdeviceplugin.yaml), so resorted to documenting the annotation configurability through CR.

[tkatila]

Looks good!

[ozhuraki]

@tkatila @mythi

Updated to congfigure only existing annotations in the daemonset, please take a look.

[mythi]

LGTM but changes in deviceplugin_v1_qatdeviceplugin.yaml must be dropped