vpu: remove deprecated plugin #1549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1549 +/- ##
=======================================
Coverage 49.48% 49.48%
=======================================
Files 42 42
Lines 4923 4923
=======================================
Hits 2436 2436
Misses 2345 2345
Partials 142 142 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tkatila
requested changes
Sep 26, 2023
There was a problem hiding this comment.
$ grep -sir vpu *
demo/intelvpu-job.yaml: name: intelvpu-demo-job
demo/intelvpu-job.yaml: jobgroup: intelvpu-demo
demo/intelvpu-job.yaml: jobgroup: intelvpu-demo
demo/intelvpu-job.yaml: name: intelvpu-demo-job-1
demo/intelvpu-job.yaml: vpu.intel.com/hddl: 1
deployments/vpu_plugin/overlays/xlink/add_command_args.yaml: name: intel-vpu-plugin
deployments/vpu_plugin/overlays/xlink/add_command_args.yaml: - name: intel-vpu-plugin
deployments/vpu_plugin/overlays/xlink/kustomization.yaml: name: intel-vpu-plugin
deployments/vpu_plugin/base/intel-vpu-plugin.yaml: name: intel-vpu-plugin
deployments/vpu_plugin/base/intel-vpu-plugin.yaml: app: intel-vpu-plugin
deployments/vpu_plugin/base/intel-vpu-plugin.yaml: app: intel-vpu-plugin
deployments/vpu_plugin/base/intel-vpu-plugin.yaml: app: intel-vpu-plugin
deployments/vpu_plugin/base/intel-vpu-plugin.yaml: - name: intel-vpu-plugin
deployments/vpu_plugin/base/intel-vpu-plugin.yaml: image: intel/intel-vpu-plugin:devel
deployments/vpu_plugin/base/kustomization.yaml: - intel-vpu-plugin.yaml
docs/extensions.rst: ../cmd/vpu_plugin/README.md
README.md: * `vpu.intel.com` : `hddl`
README.md: * [intelvpu-job.yaml](demo/intelvpu-job.yaml)
Should we also remove the deployments? And there are some VPU mentions in the readme.
oops, yes of course. |
tkatila
previously approved these changes
Sep 27, 2023
tkatila
previously approved these changes
Sep 27, 2023
|
@hj-johannes-lee please review |
The VPU plugin can only be used with devices that are no longer supported by upper layers, such as OpenVINO. The deprecation plan for the plugin was announced earlier this year and post v0.28 marks the date when the plugin is removed from the repo. Releases before v0.29 have the plugin available should it be needed. Signed-off-by: Mikko Ylinen <[email protected]>
fixed, thank you |
hj-johannes-lee
approved these changes
Oct 3, 2023
tkatila
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VPU plugin can only be used with devices that are
no longer supported by upper layers, such as OpenVINO.
The deprecation plan for the plugin was announced earlier
this year and v0.28 marks the date when the plugin is removed
from the repo.
Releases before v0.28 have the plugin available should it
be needed.
Fixes: #1422