support reduce op with fast implementation #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangJialei-A
force-pushed
the
wangjial/benchgc_reduce
branch
from
0b0b569 to
187548d
Compare
WangJialei-A
force-pushed
the
wangjial/benchgc_reduce
branch
from
187548d to
11ed38f
Compare
ZhennanQin
reviewed
Sep 4, 2024
| elif dtype == "u8" or dtype == "ui8": | ||
| return torch.uint8 | ||
| elif dtype == "s8" or dtype == "i8": | ||
| elif dtype in ["s8", "i8", "si8"]: |
There was a problem hiding this comment.
What do si8 and si32 mean?
There was a problem hiding this comment.
signless -> i32/i8
signed -> si32/si8
unsigned -> ui32/ui8
WangJialei-A
force-pushed
the
wangjial/benchgc_reduce
branch
from
11ed38f to
9ef7f69
Compare
xurui1995
reviewed
Sep 9, 2024
| ) | ||
| else: | ||
| raise Exception("only support splat value now") | ||
| elif isinstance(value, gc_mlir._mlir_libs._mlir.ir.IntegerAttr): |
There was a problem hiding this comment.
gc_mlir._mlir_libs._mlir.ir -> ir
WangJialei-A
force-pushed
the
wangjial/benchgc_reduce
branch
from
9ef7f69 to
92be909
Compare
WangJialei-A
force-pushed
the
wangjial/benchgc_reduce
branch
from
92be909 to
b3cbfaa
Compare
ZhennanQin
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to resolve #175