Add DMLC option to not suppress GCC's Wunused for local variables -- SIMICS-21585 #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…- SIMICS-21585 Implemented clumsily in a way that doesn't necessarily only affect local variables. This PR is more of a way to investigate the impact this has, and serve as a talking point. We likely want to report unused variables in DMLC directly instead.
❌ BlockedComment automatically created by Dependent Issues. To add or remove a dependency, please update this issue/PR description. |
|
Verification #12510790: pass |
|
Abandoned due to SIMICS-21719 (Symbol usage tracking is completely broken) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented clumsily in a way that doesn't necessarily only affect local variables.
This PR is more of a way to investigate the impact this has, and serve as a talking
point. We likely want to report unused variables in DMLC directly instead.
Depends on #237