-
Notifications
You must be signed in to change notification settings - Fork 571
feat: filters for component view (HTML report) #1840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1840 +/- ##
==========================================
- Coverage 89.58% 88.27% -1.31%
==========================================
Files 315 315
Lines 7156 7167 +11
Branches 1169 1174 +5
==========================================
- Hits 6411 6327 -84
- Misses 484 583 +99
+ Partials 261 257 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good, but I've got some style nitpicks. We probably should start using something equivalent to black/flake8 for the javascript and html eventually so CI would catch the indent stuff at least.
cve_bin_tool/output_engine/html_reports/templates/row_product.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now! Merging your other PR caused merge conflicts in both remaining ones (ugh) and it's probably going to do it again, so I'd suggest you only fix one and we'll just merge them in order.
I think they're both ready to merge other than the conflicts, so just choose one and let me know when it's ready!
Other one is merged, so you can update this one now if you want. Those two osv tests will keep failing; you can temp disable them in this pr if they bug you. |
@terriko this one is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for working on these! I'm going to ping the team that requested the report improvements so they can try them out now that this one is merged and make sure they see the new code.
simplescreenrecorder-2022-07-28_01.23.28.mp4
result: output.html.zip
closes #1614 #1830