Skip to content

Conversation

b31ngd3v
Copy link
Contributor

simplescreenrecorder-2022-07-28_01.23.28.mp4

result: output.html.zip

closes #1614 #1830

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #1840 (37bc42c) into main (1122fc7) will decrease coverage by 1.30%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##             main    #1840      +/-   ##
==========================================
- Coverage   89.58%   88.27%   -1.31%     
==========================================
  Files         315      315              
  Lines        7156     7167      +11     
  Branches     1169     1174       +5     
==========================================
- Hits         6411     6327      -84     
- Misses        484      583      +99     
+ Partials      261      257       -4     
Flag Coverage Δ
longtests 78.35% <18.18%> (-0.18%) ⬇️
win-longtests 87.24% <18.18%> (-1.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/output_engine/html.py 85.81% <18.18%> (-5.73%) ⬇️
cve_bin_tool/nvd_api.py 24.00% <0.00%> (-52.80%) ⬇️
test/test_nvd_api.py 50.87% <0.00%> (-40.36%) ⬇️
cve_bin_tool/available_fix/debian_cve_tracker.py 69.38% <0.00%> (-14.29%) ⬇️
cve_bin_tool/cli.py 77.03% <0.00%> (+0.37%) ⬆️
cve_bin_tool/cvedb.py 87.76% <0.00%> (+1.04%) ⬆️
cve_bin_tool/data_sources/osv_source.py 91.44% <0.00%> (+3.20%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, but I've got some style nitpicks. We probably should start using something equivalent to black/flake8 for the javascript and html eventually so CI would catch the indent stuff at least.

@b31ngd3v b31ngd3v requested a review from terriko August 3, 2022 08:17
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now! Merging your other PR caused merge conflicts in both remaining ones (ugh) and it's probably going to do it again, so I'd suggest you only fix one and we'll just merge them in order.

I think they're both ready to merge other than the conflicts, so just choose one and let me know when it's ready!

@b31ngd3v
Copy link
Contributor Author

b31ngd3v commented Aug 3, 2022

@terriko i fixed the merge conflict for the other pr (#1840)

@terriko
Copy link
Contributor

terriko commented Aug 3, 2022

Other one is merged, so you can update this one now if you want. Those two osv tests will keep failing; you can temp disable them in this pr if they bug you.

@b31ngd3v
Copy link
Contributor Author

b31ngd3v commented Aug 4, 2022

@terriko this one is ready

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for working on these! I'm going to ping the team that requested the report improvements so they can try them out now that this one is merged and make sure they see the new code.

@terriko terriko merged commit 0c10897 into intel:main Aug 4, 2022
@b31ngd3v b31ngd3v deleted the 1614 branch August 4, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Filters for component view (HTML reports)

3 participants