Magento 2.2.5 compatibility #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
category product indexing change in Magento 2.2, it uses one index table per store now. We are using that now after checking for the Magento version.
… index It has changed in Magento 2.2.5, so the check for the version (>= 2.2) was not correct. See https://twitter.com/sergeivaschenko/status/1032926575195574274.
schmengler
requested changes
Aug 27, 2018
| public function __construct( | ||
| Context $context, | ||
| ProductMetadataInterface $productMetadata, | ||
| ?string $connectionName = null |
There was a problem hiding this comment.
nullable types (?string) were introduced in PHP 7.1, using this signature will bump the minimum version from 7.0 to 7.1 for both, Magento 2.1 and Magento 2.2. We should be careful with this.
schmengler
approved these changes
Aug 27, 2018
we are using the object manager because the class should not appear in the constructor as it doesn't exist before Magento 2.2.5
Asynchronous indexing failed because the area code was set to "crontab" instead of "frontend".
|
One more bug fix was added to this PR. Async indexing failed because of the wrong area code, so we are emulating the frontend area now for indexing. |
the catalog_product_entity_* tables use row_id instead of entity_id as its primary key.
UrlFactoryPlugin calls
schmengler
force-pushed
the
2.2-compatibility
branch
from
be6b6ed to
1ea4799
Compare
|
@avstudnitz I updated the unit tests for area code emulation. they also reported that |
schmengler
force-pushed
the
2.2-compatibility
branch
9 times, most recently
from
9ba94c4 to
0d7d4f5
Compare
schmengler
force-pushed
the
2.2-compatibility
branch
8 times, most recently
from
64dcd09 to
0a61982
Compare
schmengler
force-pushed
the
2.2-compatibility
branch
from
ecd4398 to
9ae1d21
Compare
NOTE: Tests were failing in Magento 2.2, PHP 7.0 compatibility is not guaranteed anymore
schmengler
force-pushed
the
2.2-compatibility
branch
from
9ae1d21 to
c115ba1
Compare
|
Wercker configuration has been updated to work with current Magento 2.1 and 2.2 versions. |
schmengler
force-pushed
the
2.2-compatibility
branch
from
ed4e4d7 to
fd58712
Compare
|
It occurs in several tests that use product fixtures, possibly related to tddwizard/magento2-fixtures#13 |
schmengler
force-pushed
the
2.2-compatibility
branch
from
fd58712 to
de2adb3
Compare
Otherwise we get this error: User Error: DDL statements are not allowed in transactions in /var/www/magento/vendor/magento/framework/DB/Adapter/Pdo/Mysql.php:504.
schmengler
force-pushed
the
2.2-compatibility
branch
from
de2adb3 to
986b3c4
Compare
The scope hint wasn't displayed, as well as the "use default" check box.
…duct-assign Add indexing of products if they are assigned to a category
Fix category attributes
Skip html index if unnecessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category product indexing changed in Magento 2.2, it uses one index table per
store now. We are using that now after checking for the Magento version.