Adjust autosuggest URL to include current store id #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmengler
reviewed
May 15, 2017
| use Magento\Search\Helper\Data as Subject; | ||
| use Magento\Store\Model\StoreManagerInterface; | ||
|
|
||
| class DataPlugin |
There was a problem hiding this comment.
I think the naming Plugin\Helper\DataPlugin can be improved, it does not express much and adds needless namespace nesting. Of course, for plugins it make sense to reflect in the naming what they are intercepting, but for ex. Plugin\SearchHelperPlugin would make this even more clear.
(by the way, my original Model\Plugin\* classes should have better been in Plugin\* as well, so thanks for creating this new namespace)
schmengler
approved these changes
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.