Skip to content

Conversation

@JordanMarshall
Copy link
Contributor

@JordanMarshall JordanMarshall commented Jun 11, 2020

Adds an additional fix for re-attaching FlutterView to the engine when using multiple FlutterFragments. This is a workaround for changes introduced into the Flutter engine here.

@TrevorNeedham TrevorNeedham self-assigned this Jun 11, 2020
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

❗ No coverage uploaded for pull request base (release/student/6.8.0@50d2fbf). Click here to learn what that means.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##             release/student/6.8.0     #850   +/-   ##
========================================================
  Coverage                         ?   11.19%           
  Complexity                       ?      785           
========================================================
  Files                            ?      467           
  Lines                            ?    21700           
  Branches                         ?     3907           
========================================================
  Hits                             ?     2429           
  Misses                           ?    18933           
  Partials                         ?      338           

Copy link
Contributor

@TrevorNeedham TrevorNeedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JordanMarshall JordanMarshall merged commit 622104b into release/student/6.8.0 Jun 11, 2020
@JordanMarshall JordanMarshall deleted the student/flutter-attach-fix branch June 11, 2020 19:06
TrevorNeedham added a commit that referenced this pull request Jun 18, 2020
* [Student][RC 6.8] Version Bump (#849)

* [Student][R-6.8.0] Fix Flutter re-attach issue (#850)

* [Student][R-6.8.0] Fix missing x86_64 ABI for Flutter (#852)

* [Student][R-6.8.0] Set up NDK filters to only support armabi-v7a, arm64-v8a, and x86_64 (#854)

Co-authored-by: Jordan Marshall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants