Skip to content

coot/drop io classes 1.6 #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 12, 2024
Merged

coot/drop io classes 1.6 #56

merged 4 commits into from
Sep 12, 2024

Conversation

coot
Copy link
Collaborator

@coot coot commented Sep 11, 2024

  • Revert "Allow to use io-classes-1.7"
  • Revert "Use io-classes-1.6"
  • Depend on io-classes-1.5
  • typed-protocols: CHANGELOG file

crocodile-dentist
crocodile-dentist approved these changes Sep 11, 2024
View reviewed changes
Copy link

@crocodile-dentist crocodile-dentist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot coot force-pushed the coot/drop-io-classes-1.6 branch from 72e49af to 97f83ac Compare September 12, 2024 07:45
@coot
Copy link
Collaborator Author

coot commented Sep 12, 2024

There was a warning (turned into a compilation error thanks to -Werror). It's fixed now, as a result typed-protocols-cborg needs to depend on io-classes ^>= 1.5.

@coot coot added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit f3277f6 Sep 12, 2024
16 checks passed
@coot coot deleted the coot/drop-io-classes-1.6 branch September 12, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crocodile-dentist crocodile-dentist crocodile-dentist approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coot @crocodile-dentist