Skip to content

Update/correct boot packages list. #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/Stack2nix/Render.hs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,18 @@ import Text.PrettyPrint.HughesPJClass (Doc, fcat, nest,
pPrint, punctuate,
semi, space, text)

-- TODO: this only covers GHC 8.0.2
-- Boot packages (wired-in and non-wired-in).
-- These are set to `null` in the generated nix package set.
-- The wired-in packages follow
-- * https://github.com/commercialhaskell/stack/blob/d8e942ea69eb189f67a045f0c595612034dbb75d/src/Stack/Constants.hs#L102
-- * https://downloads.haskell.org/~ghc/7.10.1/docs/html/libraries/ghc/src/Module.html#integerPackageKey
-- For recent GHC releases:
-- * https://github.com/ghc/ghc/blob/ghc-8.2.2-release/compiler/basicTypes/Module.hs#L1073
-- * https://github.com/ghc/ghc/blob/ghc-8.4.4-release/compiler/basicTypes/Module.hs#L1078
-- * https://github.com/ghc/ghc/blob/ghc-8.6.4-release/compiler/basicTypes/Module.hs#L1066 (got rid of "dph-seq" and "dph-par")
-- * https://github.com/ghc/ghc/blob/334dd6da47326f47b/compiler/basicTypes/Module.hs#L1088 (in-progress 8.8)
-- TODO: This should probably be dependent on the GHC version used.
-- A split into wired-in and not-wired-in packages may also be advisable.
basePackages :: Set String
basePackages = Set.fromList
[ "array"
Expand All @@ -53,15 +64,21 @@ basePackages = Set.fromList
, "containers"
, "deepseq"
, "directory"
, "dph-par" -- for GHC < 8.6
, "dph-seq" -- for GHC < 8.6
, "filepath"
, "ghc"
, "ghc-boot"
, "ghc-boot-th"
, "ghc-prim"
, "ghci"
, "haskeline"
, "hoopl"
, "hpc"
, "integer-gmp"
, "integer-gmp" -- for GHC < 8.8
, "integer-simple" -- for GHC < 8.8
, "integer-wired-in" -- for GHC >= 8.8, see https://gitlab.haskell.org/ghc/ghc/commit/fc2ff6dd7496a33bf68165b28f37f40b7d647418
, "interactive"
, "pretty"
, "process"
, "rts"
Expand Down